Fixed #17363 - Emdash Character Encoding error #18019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipe
reviewed
Oct 9, 2025
| $table->integer('category_id')->nullable(); | ||
| $table->timestamps(); | ||
| $table->engine = 'InnoDB'; | ||
| //making a note here. Interestingly we state the model and modelno cloumns as strings. Tableplus stores as a var_string. |
There was a problem hiding this comment.
I don't think this note is needed here?
There was a problem hiding this comment.
ya, PR is in draft. the notes everywhere are a reason for that.
|
Slinging this actually as it works in my testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the encoding error seen in #17363
Additionally, on Mac OS, this can also be fixed by importing the file through excel, and NOT opening it through the OS shell.
In excel, you can then import as csv, and choose UTF-8