Clean up code

Author: Altonss

app/src/main/java/de/grobox/transportr/trips/BaseViewHolder.kt

@@ -89,7 +89,7 @@ internal abstract class BaseViewHolder(v: View) : RecyclerView.ViewHolder(v) {
         if (position == null) {
             visibility = GONE
         } else {
-            text = "${context.getString(R.string.platform, position.toString())}"
+            text = context.getString(R.string.platform, position.toString())
             visibility = VISIBLE
         }
     }

app/src/main/java/de/grobox/transportr/trips/detail/TripDrawer.kt

@@ -135,8 +135,7 @@ internal class TripDrawer(context: Context) : MapDrawer(context) {
     @ColorInt
     private fun getBackgroundColor(leg: Leg): Int {
         if (leg is Public) {
-            val line = leg.line
-            return TransportrUtils.getLineColor(context, line)
+            return TransportrUtils.getLineColor(context, leg.line)
         }
         return ContextCompat.getColor(context, R.color.walking)
     }

app/src/main/java/de/grobox/transportr/trips/detail/TripUtils.kt

@@ -108,7 +108,7 @@ internal object TripUtils {
         if (leg is Trip.Public) {
             // show departure position if existing
             if (leg.departurePosition != null) {
-                str += " (" + context.getString(R.string.platform, leg.departurePosition.toString()) +")"
+                str += " (${context.getString(R.string.platform, leg.departurePosition.toString())})"
             }
             str += "\n  ${getEmojiForProduct(leg.line?.product)} "
             leg.line?.label?.let {

app/src/main/java/de/grobox/transportr/ui/LineView.kt

@@ -57,7 +57,7 @@ class LineView(context: Context, attr: AttributeSet?) : AppCompatTextView(contex
 
         // set colored label
         text = line.label
-        if (foregroundColor != null) setTextColor(getTextColorBasedOnBackground(backgroundColor))
+        setTextColor(foregroundColor)
     }
 
     fun setWalk() {