-
Notifications
You must be signed in to change notification settings - Fork 200
feat: add riscv64 arch #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc1f8c1
to
b08a9ac
Compare
Do you actually need this, or building it for fun? |
Yes, I need this. I am using it for health checking few apps, one of which is k3s-io/kine while serving with mTLS, which Kubernetes does not support natively. |
If |
It’s not like |
Ah, I just noticed that the probe is built using quite old |
Feel free to bump ko in your fork and tag a release there to test. |
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
How does it look? Does it build correctly? |
I triggered the release, everything looks fine:
HOWEVER, according to the following issue, GoogleContainerTools/distroless#1269, and the general build process of distroless images, |
Added riscv64 to goreleaser. Unfortunately
ko
does not support building forriscv64
(base image limitation).