Skip to content

feat: add riscv64 arch #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

shanduur
Copy link
Contributor

Added riscv64 to goreleaser. Unfortunately ko does not support building for riscv64 (base image limitation).

@shanduur shanduur force-pushed the feat-riscv64 branch 2 times, most recently from cc1f8c1 to b08a9ac Compare April 22, 2025 12:03
@ahmetb
Copy link
Collaborator

ahmetb commented Apr 22, 2025

Do you actually need this, or building it for fun?

@shanduur
Copy link
Contributor Author

shanduur commented Apr 22, 2025

Yes, I need this. I am using it for health checking few apps, one of which is k3s-io/kine while serving with mTLS, which Kubernetes does not support natively.

@ahmetb
Copy link
Collaborator

ahmetb commented Apr 22, 2025

If ko is failing to build this image, I suspect the post-merge will be in a broken state from this point on, which is not desirable either. Are you able to find another base image that might work here?

@shanduur
Copy link
Contributor Author

shanduur commented Apr 22, 2025

It’s not like ko is failing - it’s jus not building riscv64, as base image cgr.dev/chainguard/static is only x86_64 and amd64.

@shanduur
Copy link
Contributor Author

Ah, I just noticed that the probe is built using quite old ko version, I’m not sure what’s the base image is then…

@ahmetb
Copy link
Collaborator

ahmetb commented Apr 23, 2025

Feel free to bump ko in your fork and tag a release there to test.

shanduur added 2 commits May 4, 2025 12:18
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
@ahmetb
Copy link
Collaborator

ahmetb commented May 4, 2025

How does it look? Does it build correctly?

@shanduur
Copy link
Contributor Author

shanduur commented May 4, 2025

I triggered the release, everything looks fine:

linux/riscv64 binary is published and works as it should. There is no well known image with linux/riscv64 support that is minimal enough, thus there is no OCI image with this tuple published.

HOWEVER, according to the following issue, GoogleContainerTools/distroless#1269, and the general build process of distroless images, riscv64 will be supported once the support is released in Debian Trixie. This won't require any changes in the grpc-health-probe - just a new tag to trigger a release.

@ahmetb ahmetb merged commit 93b3a2d into grpc-ecosystem:master May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants