fix: Server exception handler interceptor order#1192
Open
jonwillard wants to merge 2 commits into
Open
Conversation
jonwillard
changed the title
Author
|
Can you please review @ST-DDT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
GrpcExceptionInterceptorbean after theObservationGrpcServerInterceptorand theMetricCollectingServerInterceptorand before theExceptionTranslatingServerInterceptor.This builds off #1134 by adding tests requested by @ST-DDT
This resolves an issue where metrics emitted always report
UNKNOWNstatus code when@GrpcAdviceis used to handle exceptions. I have tested and deployed a gRPC server application that uses this library with the fix from this branch and the metrics correctly report status as expected.Fixes: #789 #1088