Skip to content

Conversation

aran
Copy link
Contributor

@aran aran commented Dec 4, 2024

Removes HttpStatus from io_bits, thereby breaking the dependency on dart:html.

Code that previously used HttpStatus from dart:html or dart:io now gets it from package:web.

Alternatively, this could instead use HttpStatus from dart:io on platforms with dart:io and get it from package:web only otherwise. If that's preferred we can do it that way.

Copy link

github-actions bot commented Dec 4, 2024

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
grpc Breaking 4.0.1 4.0.2-wip 5.0.0
Got "4.0.2-wip" expected >= "5.0.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
lib/src/shared/io_bits/io_bits.dart 💔 Not covered
lib/src/shared/io_bits/io_bits_web.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
grpc $1.Duration
Any

This check can be disabled by tagging the PR with skip-leaking-check.

@mosuem
Copy link
Contributor

mosuem commented Dec 10, 2024

Code that previously used HttpStatus from dart:html or dart:io now gets it from package:web.

You mean the user has to import that himself, right?

Alternatively, this could instead use HttpStatus from dart:io on platforms with dart:io and get it from package:web only otherwise. If that's preferred we can do it that way.

At first glance that sounds preferable and less breaking.

@aran aran marked this pull request as draft December 10, 2024 16:33
@aran
Copy link
Contributor Author

aran commented Dec 14, 2024

At first glance that sounds preferable and less breaking.

Switched.

@aran aran marked this pull request as ready for review December 14, 2024 07:00
@mosuem
Copy link
Contributor

mosuem commented Dec 17, 2024

LGTM, but please add a changelog and rev the version so that the health check stops complaining :)

@aran
Copy link
Contributor Author

aran commented Feb 20, 2025

@mosuem should be good to go here (?)

@mosuem mosuem merged commit 5ba28e3 into grpc:master Feb 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants