Skip to content

Commit 83538cd

Browse files
cronet: Delete TODO for User-Agent on CronetEngine
gRPC doesn't create the CronetEngine, so even though streaming is observing the CronetEngine's User-Agent, we don't have control of that. In addition, CronetEngines are commonly shared between gRPC and normal HTTP traffic, so we don't actually expect users to set gRPC in engine's user agent. The existing behavior seems to be working as well as feasible. Fixes #11582
1 parent d124007 commit 83538cd

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

cronet/src/main/java/io/grpc/cronet/CronetClientStream.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,6 @@ private static boolean isApplicationHeader(String key) {
362362
private void setGrpcHeaders(BidirectionalStream.Builder builder) {
363363
// Psuedo-headers are set by cronet.
364364
// All non-pseudo headers must come after pseudo headers.
365-
// TODO(ericgribkoff): remove this and set it on CronetEngine after crbug.com/588204 gets fixed.
366365
builder.addHeader(USER_AGENT_KEY.name(), userAgent);
367366
builder.addHeader(CONTENT_TYPE_KEY.name(), GrpcUtil.CONTENT_TYPE_GRPC);
368367
builder.addHeader("te", GrpcUtil.TE_TRAILERS);

0 commit comments

Comments
 (0)