Skip to content

Commit a2e1ea8

Browse files
authored
Remove '@_exported import GRPCCore' (#25)
Motivation: We added '@_exported import GRPCCore' to transport modules to make it easier for users as it saves them from adding an import. On reflection we've our position on this has changed and the implicit dependency will likely make things less clear. Modifications: - Remove exported import of GRPCCore Result: More explicit dependencies
1 parent 058c8ca commit a2e1ea8

File tree

5 files changed

+2
-3
lines changed

5 files changed

+2
-3
lines changed

Package.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ let targets: [Target] = [
138138
name: "GRPCNIOTransportHTTP2Tests",
139139
dependencies: [
140140
.target(name: "GRPCNIOTransportHTTP2"),
141+
.product(name: "GRPCCore", package: "grpc-swift"),
141142
.product(name: "X509", package: "swift-certificates"),
142143
.product(name: "NIOSSL", package: "swift-nio-ssl"),
143144
],

Sources/GRPCNIOTransportHTTP2/Exports.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
@_exported import GRPCCore
1817
@_exported import GRPCNIOTransportCore
1918
@_exported import GRPCNIOTransportHTTP2Posix
2019
@_exported import GRPCNIOTransportHTTP2TransportServices

Sources/GRPCNIOTransportHTTP2Posix/Exports.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,4 @@
1414
* limitations under the License.
1515
*/
1616

17-
@_exported import GRPCCore
1817
@_exported import GRPCNIOTransportCore

Sources/GRPCNIOTransportHTTP2TransportServices/Exports.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,4 @@
1414
* limitations under the License.
1515
*/
1616

17-
@_exported import GRPCCore
1817
@_exported import GRPCNIOTransportCore

Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import Crypto
1818
import Foundation
19+
import GRPCCore
1920
import GRPCNIOTransportHTTP2Posix
2021
import NIOSSL
2122
import SwiftASN1

0 commit comments

Comments
 (0)