Skip to content

Conversation

rnro
Copy link
Collaborator

@rnro rnro commented Nov 6, 2024

Motivation:

  • Tidy up soundness checks in GitHub UI.
  • Ensure checks don't run on generated code.

Modifications:

  • Soundness checks are now nested in a re-usable workflow so they are grouped in the GitHub UI as in other gRPC repos.
  • ignore generated .pb.swift and .grpc.swift files.

Result:

Tidier, more appropriate checks.

Motivation:

* Tidy up soundness checks in GitHub UI.
* Ensure checks don't run on generated code.

Modifications:

* Soundness checks are now nested in a re-usable workflow so they are
  grouped in the GitHub UI as in other gRPC repos.
* ignore generated `.pb.swift` and `.grpc.swift` files.

Result:

Tidier, more appropriate checks.
@rnro rnro added the 🔨 semver/patch No public API change. label Nov 6, 2024
@rnro rnro requested a review from glbrntt November 6, 2024 16:56
@glbrntt glbrntt added semver/none No version bump required. and removed 🔨 semver/patch No public API change. labels Nov 7, 2024
@glbrntt glbrntt enabled auto-merge (squash) November 7, 2024 12:53
@glbrntt glbrntt disabled auto-merge November 7, 2024 13:00
@glbrntt glbrntt merged commit 058c8ca into main Nov 7, 2024
36 of 39 checks passed
@glbrntt glbrntt deleted the ci_cleanup branch November 7, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants