Skip to content

Commit 56208bd

Browse files
committed
Change KERNEL_IMAGE to QEMU_KERNEL_IMAGE
1 parent 639bd02 commit 56208bd

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,10 @@ jobs:
156156

157157
- name: Run kernel
158158
run: |
159-
KERNEL_IMAGE=./kernel-image/$IMAGE_NAME make run
160-
KERNEL_IMAGE=./kernel-image/$IMAGE_NAME ROOTFS=./rootfs-${{ matrix.arch }} make run
161-
KERNEL_IMAGE=./kernel-image/$IMAGE_NAME INITRD=./alpine-${{ matrix.arch }}.cpio.gz make run
162-
KERNEL_IMAGE=./kernel-image/$IMAGE_NAME CPU=2 MEM=2048M QEMU_EXTRA_ARGS="" QEMU_EXTRA_KERNEL_CMDLINE="nokaslr" make run
159+
QEMU_KERNEL_IMAGE=./kernel-image/$IMAGE_NAME make run
160+
QEMU_KERNEL_IMAGE=./kernel-image/$IMAGE_NAME ROOTFS=./rootfs-${{ matrix.arch }} make run
161+
QEMU_KERNEL_IMAGE=./kernel-image/$IMAGE_NAME INITRD=./alpine-${{ matrix.arch }}.cpio.gz make run
162+
QEMU_KERNEL_IMAGE=./kernel-image/$IMAGE_NAME CPU=2 MEM=2048M QEMU_EXTRA_ARGS="" QEMU_EXTRA_KERNEL_CMDLINE="nokaslr" make run
163163
164164
- name: Upload rootfs artifact
165165
uses: actions/upload-artifact@v3

Makefile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ help:
6666
@echo ' MEM - Specify the memory size in MB to use when running QEMU (default: 1024)'
6767
@echo ' QEMU_EXTRA_ARGS - Specify additional arguments to pass to QEMU (default: "")'
6868
@echo ' QEMU_EXTRA_KERNEL_CMDLINE - Specify additional arguments to pass to the kernel (default: "")'
69-
@echo ' KERNEL_IMAGE - The path to the kernel image to run (x86_64 default: $$LINUX_OUT/arch/$$ARCH/boot/bzImage, arm64 default: $$LINUX_OUT/arch/$$ARCH/boot/Image)'
69+
@echo ' QEMU_KERNEL_IMAGE - The path to the kernel image to run (x86_64 default: $$LINUX_OUT/arch/$$ARCH/boot/bzImage, arm64 default: $$LINUX_OUT/arch/$$ARCH/boot/Image)'
7070
@echo ' ROOTFS - The path to the rootfs image file (default: rootfs/rootfs-$$ARCH.img)'
7171
@echo ' ROOTFS_FORMAT - The format of the rootfs image file (default: qcow2)'
7272
@echo ' INITRD - The path to a gziped initramfs CPIO file to use instead of a rootfs image (default: "")'
@@ -131,10 +131,10 @@ LINUX_CONFIG := $(LINUX_OUT)/.config
131131

132132
ifeq ($(ARCH),x86_64)
133133
TARGET := x86_64-pc-linux-gnu
134-
KERNEL_IMAGE ?= $(LINUX_OUT)/arch/$(ARCH)/boot/bzImage
134+
KERNEL_IMAGE := $(LINUX_OUT)/arch/$(ARCH)/boot/bzImage
135135
else ifeq ($(ARCH),arm64)
136136
TARGET := aarch64-linux-gnu
137-
KERNEL_IMAGE ?= $(LINUX_OUT)/arch/$(ARCH)/boot/Image
137+
KERNEL_IMAGE := $(LINUX_OUT)/arch/$(ARCH)/boot/Image
138138
endif
139139

140140
LINUX_MAKE := \
@@ -291,13 +291,14 @@ QEMU_EXTRA_KERNEL_CMDLINE ?=
291291
GDB ?= 0
292292
INITRD ?=
293293
RDINIT ?= /sbin/init
294+
QEMU_KERNEL_IMAGE ?= $(KERNEL_IMAGE)
294295

295296
QEMU_ARGS := \
296297
-m $(MEM) \
297298
-smp $(CPU) \
298299
-nographic \
299300
-no-reboot \
300-
-kernel $(KERNEL_IMAGE) \
301+
-kernel $(QEMU_KERNEL_IMAGE) \
301302
-netdev user,id=eth0,hostfwd=tcp::7777-:7777,hostfwd=tcp::2222-:22,hostfwd=tcp::2223-:23 -device virtio-net-pci,netdev=eth0 \
302303
-virtfs local,security_model=mapped-xattr,path=$(SHARED_DIR),mount_tag=shared \
303304
$(QEMU_EXTRA_ARGS)
@@ -334,7 +335,7 @@ else
334335
-append "console=ttyAMA0 selinux=0 $(QEMU_EXTRA_KERNEL_CMDLINE)"
335336
endif
336337

337-
RUN_DEPS := $(KERNEL_IMAGE)
338+
RUN_DEPS := $(QEMU_KERNEL_IMAGE)
338339

339340
.PHONY: run
340341
run: $(RUN_DEPS) | $(SHARED_DIR)

0 commit comments

Comments
 (0)