Skip to content

gio: DataInputStream::read_line_async() can return None slices #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

gio: DataInputStream::read_line_async() can return None slices #1803

merged 2 commits into from
Aug 27, 2025

Conversation

sdroege
Copy link
Member

@sdroege sdroege commented Aug 27, 2025

Fixes #1802

@sdroege sdroege requested a review from bilelmoussaoui August 27, 2025 06:50
@sdroege sdroege mentioned this pull request Aug 27, 2025
Closed
@sdroege sdroege added the needs-backport PR needs backporting to the current stable branch label Aug 27, 2025
@sdroege sdroege merged commit a9bb174 into gtk-rs:main Aug 27, 2025
48 checks passed
@sdroege sdroege deleted the gio-data-input-stream-read-line branch August 27, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui Awaiting requested review from bilelmoussaoui

Assignees
No one assigned
Labels
needs-backport PR needs backporting to the current stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

read_line_async crashing because of assertion
1 participant
@sdroege