fix(gtk4): remove deprecated warnings on style_context methods #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was this merged? this is incorrect. Those are just functions and are not part of that type. |
|
This is indeed confusing. Sorry for missing that, I'll revert |
|
Reverted |
|
Sorry I'm not sure I understand? I have spotted I've removed the doc aliases which is definitely incorrect. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate incorrectly marks the bindings to
gtk_style_context_add_provider_for_displayandgtk_style_context_remove_provider_for_displayas deprecated, linking to the same methods as alternatives.The official docs do not mark this functions as deprecated:
https://docs.gtk.org/gtk4/type_func.StyleContext.add_provider_for_display.html
https://docs.gtk.org/gtk4/type_func.StyleContext.remove_provider_for_display.html