-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add playwright tests that do not require cucumber feature files #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add playwright tests that do not require cucumber feature files #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @carlosthe19916, your pull request is too large to review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 57.28% 63.21% +5.93%
==========================================
Files 146 150 +4
Lines 2430 2474 +44
Branches 552 561 +9
==========================================
+ Hits 1392 1564 +172
+ Misses 833 687 -146
- Partials 205 223 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
# Conflicts: # .devcontainer/template.json
afd3bbd
to
07f30d6
Compare
Reviewer's GuideThis PR migrates the existing end-to-end tests from the trustify-tests repository into native Playwright tests, eliminating the need for Cucumber feature files. It introduces a suite of reusable page object models (Toolbar, Table, Pagination, DetailsPageLayout, LabelsModal, Navigation, Helpers), entity-specific page classes (ListPage, DetailsPage, Tab classes for Advisories, Packages, SBOMs, Vulnerabilities), and comprehensive spec files covering sorting, filtering, pagination, and UI actions. The configuration has also been updated to support the new test setup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider DRY-ing up the nearly identical Tab classes by extracting a generic base or factory to reduce boilerplate and maintenance overhead.
- Many page objects expose internal Locator fields (e.g. _toolbar, _table) publicly – make those private or provide explicit methods to better encapsulate implementation details.
- Navigation.goToSidebar always starts by calling
/upload
; this indirection can slow or break tests—consider parameterizing the entry path or navigating directly to the target page.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider DRY-ing up the nearly identical Tab classes by extracting a generic base or factory to reduce boilerplate and maintenance overhead.
- Many page objects expose internal Locator fields (e.g. _toolbar, _table) publicly – make those private or provide explicit methods to better encapsulate implementation details.
- Navigation.goToSidebar always starts by calling `/upload`; this indirection can slow or break tests—consider parameterizing the entry path or navigating directly to the target page.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Summary by Sourcery
Migrate existing Trustify-tests and add a full Playwright-based E2E test suite with page object models and spec files for core application pages
New Features:
Enhancements:
Tests: