-
Notifications
You must be signed in to change notification settings - Fork 735
Open
Copy link
Milestone
Description
This Issue will be tackled after #4148 has been closed.
Carefully following the proposal here:
./docfx/docs/runnable-architecture-proposal.md
Phase 1 is completed. You are implementing phase 2 as described near the end.
Work to be done to close this Issue:
- Make Toplevel implement IRunnable (adapter pattern for compatibility)
- Update Dialog to inherit from Runnable instead of Window
- Update MessageBox to use Dialog.Result
- Update Wizard to inherit from Runnable
- Update all examples to use new IRunnable pattern
- Update the new FluentExample to define POST_4148 and ensure it works
- Create a NEW set of parallelizable unit tests that extensively tests all of the above. DO NOT ASSUME THE EXISTING TESTS ARE ANY GOOD. It is ok to disable old tests you deem to be poorly written, confusing, or no longer applicable. Use
Skipin the[Fact]pr[Theory].
Exit Criteria
- All XML API docs
- All relevant deep dives in ./docfx/docs have been updated
- All tests pass
- There are no new warnings
- CI/CD passes
IMPORTANT: At each step in implementing this you must:
- Revisit Replace
ToplevelwithIRunnable#4148 regularly to ensure your thinking stays on track. - Re-read ./docfx/application.md and ./docfx/View.md to ensure you still understand the nuances.
- Ensure you are following contributing.md
- Build and test to ensure all tests pass and no new warnings are introduced
Copilot
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
No status