Fixes 4191 - Rewrite WindowsOutput

Terminal.Gui/Drivers/V2/IOutputBuffer.cs

@@ -9,11 +9,6 @@ namespace Terminal.Gui.Drivers;
 /// </summary>
 public interface IOutputBuffer
 {
-    /// <summary>
-    ///     As performance is a concern, we keep track of the dirty lines and only refresh those.
-    ///     This is in addition to the dirty flag on each cell.
-    /// </summary>
-    public bool [] DirtyLines { get; }
 
     /// <summary>
     ///     The contents of the application output. The driver outputs this buffer to the terminal when UpdateScreen is called.

Terminal.Gui/Drivers/V2/MainLoopCoordinator.cs

@@ -25,7 +25,6 @@ internal class MainLoopCoordinator<T> : IMainLoopCoordinator
     private ConsoleDriverFacade<T> _facade;
     private Task _inputTask;
     private readonly ITimedEvents _timedEvents;
-    private readonly bool _isWindowsTerminal;
 
     private readonly SemaphoreSlim _startupSemaphore = new (0, 1);
 
@@ -61,7 +60,6 @@ IMainLoop<T> loop
         _inputProcessor = inputProcessor;
         _outputFactory = outputFactory;
         _loop = loop;
-        _isWindowsTerminal = Environment.GetEnvironmentVariable ("WT_SESSION") is { } || Environment.GetEnvironmentVariable ("VSAPPIDNAME") != null;
     }
 
     /// <summary>
@@ -162,11 +160,6 @@ private void BuildFacadeIfPossible ()
                            _loop.AnsiRequestScheduler,
                            _loop.WindowSizeMonitor);
 
-            if (!_isWindowsTerminal)
-            {
-                Application.Force16Colors = _facade.Force16Colors = true;
-            }
-
             Application.Driver = _facade;
 
             _startupSemaphore.Release ();

Terminal.Gui/Drivers/V2/NetOutput.cs

@@ -80,17 +80,11 @@ public void Write (IOutputBuffer buffer)
                 return;
             }
 
-            if (!buffer.DirtyLines [row])
-            {
-                continue;
-            }
-
             if (!SetCursorPositionImpl (0, row))
             {
                 return;
             }
 
-            buffer.DirtyLines [row] = false;
             output.Clear ();
 
             for (int col = left; col < cols; col++)