-
Notifications
You must be signed in to change notification settings - Fork 720
Fixes #3951. Adds View dependency to DimFunc
and PosFunc
#4210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2_develop
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is slick. Nice work.
I think it would be better if, instead of creating a new class for DimFuncWIthView
, you instead added an optional View
property to DimFunc
and added another constuctor that took a View
. Or made the existing DimFunc
constructor take an optional View
parameter.
Done. I opted for add the optional View parameter and property because is impossible to store in a property two different types |
DimFunc
and DimPos
DimFunc
and DimPos
DimFunc
and DimPos
DimFunc
and DimPos
DimFunc
and PosFunc
Fixes
NeedsLayout
should automatically know when there's a View dependency (e.g.Dim.Func()
) #3951Proposed Changes/Todos
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)