Skip to content

Conversation

stergioc
Copy link
Collaborator

This is adding the H-Optimus-0 model for tile feature extraction.

@stergioc
Copy link
Collaborator Author

Ah right! The timm library is not available by default in sopa :|

We might need to re-write the ViT giant class here to avoid the timm dept

@quentinblampey
Copy link
Collaborator

We might need to re-write the ViT giant class here to avoid the timm dept

How giant is it? If it's too big, we can consider the option of only checking if timm is installed, and send an appropriate error log if not (something like ERROR: Using the hoptimus0 model for inference requires installing the timm dependency, this can be done via 'pip install timm')

@stergioc
Copy link
Collaborator Author

Sorry, I mean the class of the ViT variant giant that is used by the h-optimus-0. The solution of adding the timm library as an optional requirement in case this model is selected for inference seem to me the best tradeoff. I will update the PR :)

@quentinblampey
Copy link
Collaborator

Sorry, I mean the class of the ViT variant giant that is used by the h-optimus-0.

Oh I see, sorry for the misunderstanding!

Looking good now, I'm merging :)

@quentinblampey quentinblampey merged commit 9cdb68d into gustaveroussy:master Feb 11, 2025
5 checks passed
@stergioc
Copy link
Collaborator Author

Ah, maybe we need also to update the docstring for the compute_embedings function.

@quentinblampey
Copy link
Collaborator

You're right, I just updated it directly on master

@stergioc stergioc deleted the hoptimus branch February 25, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants