Fix: Correct environment variable handling for limited Azure OpenAI GPT and embedding access by properly differentiating endpoints. #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PT and embedding access by properly differentiating endpoints.
|
in some collabrating project , the embedding azure and completion azure might not be the same endpoint , but in current code the azure client fail to deal with them seperately |
|
LGTM! Would you like to also add related docs in readme, for azure openai ? |
gusye1234
reviewed
Dec 26, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| import aioboto3 | |||
| from openai import AsyncOpenAI, AsyncAzureOpenAI, APIConnectionError, RateLimitError | |||
| from azure.core.exceptions import HttpResponseError | |||
There was a problem hiding this comment.
You should add azure dep in requirement.txt
There was a problem hiding this comment.
wait there is no Azure in requirement? shiii,sorry for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.