build system improvements:

	I) Better names for makefile variables.
	II) Improved documentation on build types in the md files.
	III) Removed redundant parameters in build.sh & Improved
internal documentation

Author: guyush1

Makefile

@@ -1,11 +1,11 @@
 ARCHS := x86_64 arm aarch64 powerpc mips mipsel
 GDB_BFD_ARCHS := $(shell echo $(ARCHS) | awk '{for(i=1;i<=NF;i++) $$i=$$i"-linux"; print}' OFS=,)
 
-BASE_TARGETS := $(addprefix build-, $(ARCHS))
+BASE_BUILD_TARGETS := $(addprefix build-, $(ARCHS))
 
-SLIM_TARGETS := $(addsuffix -slim, $(BASE_TARGETS))
-FULL_TARGETS := $(addsuffix -full, $(BASE_TARGETS))
-ALL_TARGETS := $(SLIM_TARGETS) $(FULL_TARGETS)
+SLIM_BUILD_TARGETS := $(addsuffix -slim, $(BASE_BUILD_TARGETS))
+FULL_BUILD_TARGETS := $(addsuffix -full, $(BASE_BUILD_TARGETS))
+ALL_BUILD_TARGETS := $(SLIM_BUILD_TARGETS) $(FULL_BUILD_TARGETS)
 
 BASE_PACK_TARGETS := $(addprefix pack-, $(ARCHS))
 
@@ -20,7 +20,7 @@ BUILD_PACKAGES_DIR := "build/packages"
 # This is disabled by the ci automation manually.
 TTY_ARG ?= -it
 
-.PHONY: clean help download_packages build build-docker-image $(ALL_TARGETS) $(ALL_PACK_TARGETS)
+.PHONY: clean help download_packages build build-docker-image $(ALL_BUILD_TARGETS) $(ALL_PACK_TARGETS)
 
 .NOTPARALLEL: build pack
 
@@ -29,7 +29,7 @@ help:
 	@echo "  make build"
 	@echo ""
 
-	@for target in $(ALL_TARGETS); do \
+	@for target in $(ALL_BUILD_TARGETS); do \
 		echo "  $$target"; \
 	done
 
@@ -58,12 +58,12 @@ symlink-git-packages: build/symlink-git-packages.stamp
 
 download-packages: build/download-packages.stamp
 
-build: $(ALL_TARGETS)
+build: $(ALL_BUILD_TARGETS)
 
-$(SLIM_TARGETS): build-%-slim:
+$(SLIM_BUILD_TARGETS): build-%-slim:
 	@BUILD_TYPE="slim" $(MAKE) _build-$*
 
-$(FULL_TARGETS): build-%-full:
+$(FULL_BUILD_TARGETS): build-%-full:
 	@BUILD_TYPE="full" GDB_BFD_ARCHS=$(GDB_BFD_ARCHS) $(MAKE) _build-$*
 
 _build-%: symlink-git-packages download-packages build-docker-image

README.md

@@ -60,17 +60,22 @@ This is where `gdb-static` comes in! We provide static builds of `gdb` (and `gdb
 
 ## Usage 
 
-To get started with `gdb-static`, simply download the build for your architecture from the [releases page](https://github.com/guyush1/gdb-static/releases/latest), extract the archive, and copy the binary to your desired platform.
-
-> [!NOTE]
-> We provide two types of builds:
-> 1. Full builds with Python support && cross-architecture debugging, ~70MB in size. Note that we disable the simulator feature in order to enable cross-architecture debugging (since not all targets have a simulator).
-> 2. Slim builds, which are approximately ~10 MB in size.
->
-> Full builds are modular - you can edit full_build_conf.sh to disable parts of the full builds.
+To get started with `gdb-static`, simply download the build for your architecture from the [releases page](https://github.com/guyush1/gdb-static/releases/latest), extract the archive, and copy the binary to your desired platform. <br />
 
 You may choose to copy the `gdb` binary to the platform, or use `gdbserver` to debug remotely.
 
+## Build types
+
+We provide two types of builds:
+1. Slim builds, that contains most of the features, beside the ones mentioned below.
+2. Full builds that contains all of the slim build features, and also contains:
+   * Python support
+   * Cross-architecture debugging. <br />
+   Note that in order to enable cross-architecture debugging, we have to disable the simulator feature, since not all targets have a simulator.
+
+Slim builds are approximately ~10MB. Full builds are approximately ~70MB. <br />
+You can edit the full_build_conf.sh file to disable full build exclusive features. 
+
 ## Development
 
 > [!NOTE]
@@ -102,7 +107,7 @@ To build `gdb-static` for a specific architecture, run the following command:
 make build-<ARCH>-[slim/full]
 ```
 
-Where `<ARCH>` is the architecture you want to build for, and `slim/full` determines the build type (see note about builds above).
+Where `<ARCH>` is the architecture you want to build for, and `slim/full` determines the build type (see [here](#build-types)).
 
 The resulting binary will be placed in the `build/artifacts/` directory:
 

src/compilation/build.sh

@@ -510,9 +510,8 @@ function build_gdb() {
     # $4: libgmp prefix
     # $5: libmpfr prefix
     # $6: liblzma prefix
-    # $7: whether to build gdb with all extra configurations specified in src/compilation/full_build_conf.sh
+    # $7: build mode: slim / full.
     # $8: gdb cross-architecture binary format support formats (relevant for full builds only).
-    # $9: the architecture we are compiling for.
     #
     # Echoes:
     # The gdb build directory
@@ -529,7 +528,6 @@ function build_gdb() {
     local liblzma_prefix="$6"
     local full_build="$7"
     local gdb_bfd_archs="$8"
-    local target_arch="$9"
 
     local extra_flags=()
     if [[ "$full_build" == "yes" ]]; then
@@ -543,10 +541,10 @@ function build_gdb() {
             extra_flags+=("--without-python")
         fi
 
-        local gdb_build_dir="$(realpath "$gdb_dir/build-${target_arch}_full")"
+        local gdb_build_dir="$(realpath "$gdb_dir/build-${target_arch}-full")"
     else
         extra_flags+=("--without-python")
-        local gdb_build_dir="$(realpath "$gdb_dir/build-${target_arch}_slim")"
+        local gdb_build_dir="$(realpath "$gdb_dir/build-${target_arch}-slim")"
     fi
 
     echo "$gdb_build_dir"
@@ -595,7 +593,7 @@ function install_gdb() {
     # $1: gdb build directory
     # $2: artifacts directory
     # $3: target architecture
-    # $4: whether to build gdb with all extra configurations specified in src/compilation/full_build_conf.sh
+    # $4: build mode: slim / full.
     #
     # Returns:
     # 0: success
@@ -643,7 +641,7 @@ function build_and_install_gdb() {
     # $3: libgmp prefix
     # $4: libmpfr prefix
     # $5: liblzma prefix.
-    # $6: whether to build gdb with all extra configurations specified in src/compilation/full_build_conf.sh
+    # $6: build mode: slim / full.
     # $7: gdb cross-architecture binary format support formats (relevant for full builds only).
     # $8: install directory
     # $9: target architecture
@@ -662,7 +660,7 @@ function build_and_install_gdb() {
     local artifacts_dir="$8"
     local target_arch="$9"
 
-    gdb_build_dir="$(build_gdb "$gdb_dir" "$target_arch" "$libiconv_prefix" "$libgmp_prefix" "$libmpfr_prefix" "$liblzma_prefix" "$full_build" "$gdb_bfd_archs" "$target_arch")"
+    gdb_build_dir="$(build_gdb "$gdb_dir" "$target_arch" "$libiconv_prefix" "$libgmp_prefix" "$libmpfr_prefix" "$liblzma_prefix" "$full_build" "$gdb_bfd_archs")"
     if [[ $? -ne 0 ]]; then
         return 1
     fi
@@ -680,7 +678,7 @@ function build_gdb_with_dependencies() {
     # $1: target architecture
     # $2: build directory
     # $3: src directory
-    # $4: whether to build gdb with all extra configurations specified in src/compilation/full_build_conf.sh
+    # $4: build mode: slim / full.
     # $5: gdb cross-architecture binary format support formats (relevant for full builds only).
 
     local target_arch="$1"