Skip to content

build: add mips & mipsel targets #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2024
Merged

build: add mips & mipsel targets #13

merged 1 commit into from
Nov 10, 2024

Conversation

guyush1
Copy link
Owner

@guyush1 guyush1 commented Nov 8, 2024

No description provided.

@guyush1 guyush1 requested a review from RoiKlevansky November 8, 2024 11:40
@guyush1 guyush1 self-assigned this Nov 8, 2024
Copy link
Collaborator

@RoiKlevansky RoiKlevansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@RoiKlevansky
Copy link
Collaborator

Glad to see how extendable the code is!
It's also really cool to see the pipeline working.

@RoiKlevansky
Copy link
Collaborator

RoiKlevansky commented Nov 9, 2024

I want to confirm this with you. You only added builds for the 32-bit version of Mips and Mipsle.
Expanding this to the 64-bit variants is as simple as adding a couple of lines.
Are we sure that only the 32-bit versions are relevant?
@guyush1

@guyush1
Copy link
Owner Author

guyush1 commented Nov 10, 2024

@RoiKlevansky yes, as i understand 64-bit variants of mips are rare.

@guyush1 guyush1 changed the base branch from improve-documentation to develop November 10, 2024 20:27
@guyush1 guyush1 merged commit d5e1dbb into develop Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants