Update : Removed the unused code and cleaned files with unnecessary code #572
+23
−837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for creating a PR for your Issue!
|
✅ Deploy Preview for growcraftt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey , @gyanshankar1708 I have scaned the project directory and i found the services.html file duplicated not required so i removed the code of it , for now you can merge this pr and please clear my query question so that i can move forward if we have to remove the other folder as well |
|
@Codeboy20 ressolve Conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
As of now i have removed the unused code from the file but not deleted the file from the directory for future aspect and also edited some code in index.html file mentioned in previous pr ,
Query -
I just want to know that whether we require the learn folder files as of now or not because that files are also not used and referenced to any file , making the storage bit full and also confusing for new contributers to find the actual file .
If that files are not required then for now we can also remove their code or delete entire folder but if in future they needed then we can keep them as it is .
Are these changes tested?
Yes , by removing the code from the file not affected the project and still running fine