Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 1, 2024

Bumps web-vitals from 0.2.4 to 4.2.1.

Changelog

Sourced from web-vitals's changelog.

v4.2.1 (2024-06-30)

  • Fix compatibility issues with TypeScript v5.5 (#497)

v4.2.0 (2024-06-20)

  • Refactor INP attribution code to fix errors on Windows 10 (#495)

v4.1.1 (2024-06-10)

  • Fix pending LoAF cleanup logic (#493)

v4.1.0 (2024-06-06)

  • Move the support check to the top of the onINP() function (#490)
  • Fix missing LoAF attribution when entries are dispatched before event entries (#487)

v4.0.1 (2024-05-21)

  • Add the ReportCallback type back but deprecate it (#483)

v4.0.0 (2024-05-13)

  • [BREAKING] Update types to support more generic usage (#471)
  • [BREAKING] Split waitingDuration to make it easier to understand redirect delays (#458)
  • [BREAKING] Rename TTFBAttribution fields from *Time to *Duration (#453)
  • [BREAKING] Rename resourceLoadTime to resourceLoadDuration in LCP attribution (#450)
  • [BREAKING] Add INP breakdown timings and LoAF attribution (#442)
  • [BREAKING] Deprecate onFID() and remove previously deprecated APIs (#435)
  • Expose the target element in INP attribution (#479)
  • Save INP target after interactions to reduce null values when removed from the DOM (#477)
  • Cap TTFB in attribution (#440)
  • Fix reportAllChanges behavior for LCP when library is loaded late (#468)

v3.5.2 (2024-01-25)

  • Pick the first non-null target for INP attribution (#421)

v3.5.1 (2023-12-27)

  • Add extra guard for PerformanceEventTiming not existing (#403)

v3.5.0 (2023-09-28)

  • Run onLCP callback in separate task (#386)
  • Fix INP durationThreshold bug when set to 0 (#372)
  • Prevent FID entries being emitted as INP for non-supporting browsers (#368)

v3.4.0 (2023-07-11)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [web-vitals](https://github.com/GoogleChrome/web-vitals) from 0.2.4 to 4.2.1.
- [Changelog](https://github.com/GoogleChrome/web-vitals/blob/main/CHANGELOG.md)
- [Commits](GoogleChrome/web-vitals@v0.2.4...v4.2.1)

---
updated-dependencies:
- dependency-name: web-vitals
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from sydneywalcoff as a code owner July 1, 2024 16:59
@dependabot dependabot bot added the ready for dev lead task ready for dev lead to evaluate label Jul 1, 2024
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUGE jump in version numbers. Need to investigate what is creating these errors

ERROR in src/reportWebVitals.ts:1:10
TS2305: Module '"../node_modules/web-vitals/dist/modules"' has no exported member 'ReportHandler'.
  > 1 | import { ReportHandler } from 'web-vitals';
      |          ^^^^^^^^^^^^^
    2 |
    3 | const reportWebVitals = (onPerfEntry?: ReportHandler) => {
    4 |   if (onPerfEntry && onPerfEntry instanceof Function) {

ERROR in src/reportWebVitals.ts:5:34
TS2339: Property 'getCLS' does not exist on type '{ default: typeof import("/Users/sydneywalcoff/Desktop/coding/projects/hackforla/expunge-assist/products/statement-generator/node_modules/web-vitals/dist/modules/index"); onCLS: (onReport: (metric: CLSMetric) => void, opts?: ReportOpts | undefined) => void; ... 10 more ...; FIDThresholds: MetricRatingThresholds; }'.
    3 | const reportWebVitals = (onPerfEntry?: ReportHandler) => {
    4 |   if (onPerfEntry && onPerfEntry instanceof Function) {
  > 5 |     import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
      |                                  ^^^^^^
    6 |       getCLS(onPerfEntry);
    7 |       getFID(onPerfEntry);
    8 |       getFCP(onPerfEntry);

ERROR in src/reportWebVitals.ts:5:42
TS2339: Property 'getFID' does not exist on type '{ default: typeof import("/Users/sydneywalcoff/Desktop/coding/projects/hackforla/expunge-assist/products/statement-generator/node_modules/web-vitals/dist/modules/index"); onCLS: (onReport: (metric: CLSMetric) => void, opts?: ReportOpts | undefined) => void; ... 10 more ...; FIDThresholds: MetricRatingThresholds; }'.
    3 | const reportWebVitals = (onPerfEntry?: ReportHandler) => {
    4 |   if (onPerfEntry && onPerfEntry instanceof Function) {
  > 5 |     import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
      |                                          ^^^^^^
    6 |       getCLS(onPerfEntry);
    7 |       getFID(onPerfEntry);
    8 |       getFCP(onPerfEntry);

ERROR in src/reportWebVitals.ts:5:50
TS2339: Property 'getFCP' does not exist on type '{ default: typeof import("/Users/sydneywalcoff/Desktop/coding/projects/hackforla/expunge-assist/products/statement-generator/node_modules/web-vitals/dist/modules/index"); onCLS: (onReport: (metric: CLSMetric) => void, opts?: ReportOpts | undefined) => void; ... 10 more ...; FIDThresholds: MetricRatingThresholds; }'.
    3 | const reportWebVitals = (onPerfEntry?: ReportHandler) => {
    4 |   if (onPerfEntry && onPerfEntry instanceof Function) {
  > 5 |     import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
      |                                                  ^^^^^^
    6 |       getCLS(onPerfEntry);
    7 |       getFID(onPerfEntry);
    8 |       getFCP(onPerfEntry);

ERROR in src/reportWebVitals.ts:5:58
TS2339: Property 'getLCP' does not exist on type '{ default: typeof import("/Users/sydneywalcoff/Desktop/coding/projects/hackforla/expunge-assist/products/statement-generator/node_modules/web-vitals/dist/modules/index"); onCLS: (onReport: (metric: CLSMetric) => void, opts?: ReportOpts | undefined) => void; ... 10 more ...; FIDThresholds: MetricRatingThresholds; }'.
    3 | const reportWebVitals = (onPerfEntry?: ReportHandler) => {
    4 |   if (onPerfEntry && onPerfEntry instanceof Function) {
  > 5 |     import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
      |                                                          ^^^^^^
    6 |       getCLS(onPerfEntry);
    7 |       getFID(onPerfEntry);
    8 |       getFCP(onPerfEntry);

ERROR in src/reportWebVitals.ts:5:66
TS2339: Property 'getTTFB' does not exist on type '{ default: typeof import("/Users/sydneywalcoff/Desktop/coding/projects/hackforla/expunge-assist/products/statement-generator/node_modules/web-vitals/dist/modules/index"); onCLS: (onReport: (metric: CLSMetric) => void, opts?: ReportOpts | undefined) => void; ... 10 more ...; FIDThresholds: MetricRatingThresholds; }'.
    3 | const reportWebVitals = (onPerfEntry?: ReportHandler) => {
    4 |   if (onPerfEntry && onPerfEntry instanceof Function) {
  > 5 |     import('web-vitals').then(({ getCLS, getFID, getFCP, getLCP, getTTFB }) => {
      |                                                                  ^^^^^^^
    6 |       getCLS(onPerfEntry);
    7 |       getFID(onPerfEntry);
    8 |       getFCP(onPerfEntry);

@sydneywalcoff sydneywalcoff removed the ready for dev lead task ready for dev lead to evaluate label Jul 6, 2024
@sydneywalcoff sydneywalcoff self-assigned this Jul 6, 2024
Copy link

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

2 similar comments
Copy link

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

Copy link

github-actions bot commented Aug 1, 2024

Hey @sydneywalcoff! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 7, 2024

Superseded by #1497.

@dependabot dependabot bot closed this Aug 7, 2024
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/products/statement-generator/dependencies/web-vitals-4.2.1 branch August 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant