-
-
Notifications
You must be signed in to change notification settings - Fork 844
DO NOT MERGE: docker-compose.yml has been updated to pull the test image from dockerhub #7359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
DO NOT MERGE: docker-compose.yml has been updated to pull the test image from dockerhub #7359
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 9/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes align with the ticket description, and the images on the website are loading fine in the local testing environment.
Thank you for working on this ticket.
Review ETA: 13 PM 9/22/2024 |
Putting review on hold as discussed in Sunday meeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roslynwythe everything appears to work when I run the container locally, the site is up and pages display as they should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roslynwythe, the first time I wanted to review I had an issue running docker with the changes. There was an error when pulling the image, but now it's working. I commented that on Sunday.
The changes to the source code are correct, and the site is up and running.
Thanks for working on this issue
Review ETA: 29 Jan 2025 @ 6 PM (GMT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roslynwythe , thank you for working on this.
Kudos
- The pull request is made with the correct branch.
- The PR post contains a linked issue, what changes you made and why, instructions for Reviewers/Merge Team, and the screenshot section.
- The originating issue (#7358) is assigned and added to the "In progress (actively working)" column.
- When running
docker-compose up
the site at http://localhost:4000 is working.
Suggested Changes
- You could check off the boxes of the action items in the originating issue.
- You could have also provided availability, ETA & the progress report in the originating issue.
- You could add the CodeQL Alerts section in the PR post and check off its appropriate box(es).
I have approved this PR because the changes to the docker-compose.yml
file are accurate and the site at http://localhost:4000 is working.
Nice one, thank you for your contribution! Feel free to reach out if you need help with anything.
Review ETA: EOD 3/14/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roslynwythe , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- Website is still user-friendly and links and components still work as intended.
Suggested changes:
- Linked issue checkboxes aren’t checked off for completed action items.
- Missing CodeQL Alerts checkboxes on this PR.
Notes:
- Relevant to hackforla/ops#142: Should replace
FROM ruby:3.3.4-alpine3.20 AS build
andFROM ruby:2.7.3-alpine3.13
to match new Ruby version3.4.2-alpine3.21
inDockerfile
sincegithub-pages
gem version has not changed. - Your issue branch name should relate to the issue and follow the correct scheme/format. For example, the issue Update ‘Give’ image credit link and information - #2093 should have this branch name:
update-give-link-2093
. Your issue branch name should be for #7358 . No need to change your branch name for this issue.
Thank you for your hard work @roslynwythe , I approve this PR.
Fixes #7358
What changes did you make?
docker-compose.yml
to referencehackforlaops/ghpages:testing
Why did you make the changes (we will use this info to test)?
docker-compose up
runs it will pull down the test image, recreate the container, build and server the site so that we can testInstructions for Reviewers/Merge Team
docker-compose up
and confirm that the site at http://localhost:4000 is workingScreenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website