fix/avoid race condition by preserving room until no connection #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackycute
reviewed
Jan 25, 2025
src/api.js
Outdated
| } | ||
| await this.redis.multi() | ||
| .xTrim(roomName, 'MINID', lastId - this.redisMinMessageLifetime) | ||
| .xDelIfEmpty(roomName) |
There was a problem hiding this comment.
maybe not remove stream even the room messages is empty to avoid race?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual deleting streams would lead to race conditions in a distributed architecture. This PR changed to use Redis TTL for removing inactive streams instead of manual operation.