From 2f95bcab22026e9eb218e2c3ee885b222c4dae7c Mon Sep 17 00:00:00 2001 From: cartzhang Date: Tue, 14 Mar 2017 10:45:12 +0800 Subject: [PATCH 1/2] check if exist filter and meshrender component ,or give tips --- ResourceChecker.cs | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/ResourceChecker.cs b/ResourceChecker.cs index 466c766..4d363df 100755 --- a/ResourceChecker.cs +++ b/ResourceChecker.cs @@ -133,7 +133,9 @@ enum InspectType bool collectedInPlayingMode; - [MenuItem ("Window/Resource Checker")] + System.Text.StringBuilder TmpSB = new System.Text.StringBuilder(); + + [MenuItem ("Window/Resource Checker")] static void Init () { ResourceChecker window = (ResourceChecker) EditorWindow.GetWindow (typeof (ResourceChecker)); @@ -725,8 +727,10 @@ void CheckResources() MissingObjects.Add (tMissing); thingsMissing = true; } - if (tMeshFilter.transform.GetComponent().sharedMaterial == null) { - MissingGraphic tMissing = new MissingGraphic (); + CheckMeshFilterAndRenderComponent(tMeshFilter); + if (null != tMeshFilter.transform.GetComponent() && tMeshFilter.transform.GetComponent().sharedMaterial == null) + { + MissingGraphic tMissing = new MissingGraphic (); tMissing.Object = tMeshFilter.transform; tMissing.type = "material"; tMissing.name = tMeshFilter.transform.name; @@ -1038,4 +1042,15 @@ private TextureDetails GetTextureDetail(Texture tTexture) return tTextureDetails; } + private void CheckMeshFilterAndRenderComponent(MeshFilter meshFilter) + { + if (null != meshFilter && null == meshFilter.transform.GetComponent()) + { + TmpSB.Length = 0; + TmpSB.Append(meshFilter.transform.name); + TmpSB.Append(" have meshFilter without any MeshRender,please check to add MeshRender or delete MeshFilter."); + Debug.LogError(TmpSB.ToString()); + } + } + } From d58016932f3c8a2d9279ed9b01013d34c48041d4 Mon Sep 17 00:00:00 2001 From: cartzhang Date: Tue, 14 Mar 2017 10:53:30 +0800 Subject: [PATCH 2/2] change variable name --- ResourceChecker.cs | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/ResourceChecker.cs b/ResourceChecker.cs index 4d363df..0669831 100755 --- a/ResourceChecker.cs +++ b/ResourceChecker.cs @@ -133,7 +133,7 @@ enum InspectType bool collectedInPlayingMode; - System.Text.StringBuilder TmpSB = new System.Text.StringBuilder(); + System.Text.StringBuilder tmpStringBuilder = new System.Text.StringBuilder(); [MenuItem ("Window/Resource Checker")] static void Init () @@ -728,8 +728,7 @@ void CheckResources() thingsMissing = true; } CheckMeshFilterAndRenderComponent(tMeshFilter); - if (null != tMeshFilter.transform.GetComponent() && tMeshFilter.transform.GetComponent().sharedMaterial == null) - { + if (null != tMeshFilter.transform.GetComponent() && tMeshFilter.transform.GetComponent().sharedMaterial == null) { MissingGraphic tMissing = new MissingGraphic (); tMissing.Object = tMeshFilter.transform; tMissing.type = "material"; @@ -1046,10 +1045,10 @@ private void CheckMeshFilterAndRenderComponent(MeshFilter meshFilter) { if (null != meshFilter && null == meshFilter.transform.GetComponent()) { - TmpSB.Length = 0; - TmpSB.Append(meshFilter.transform.name); - TmpSB.Append(" have meshFilter without any MeshRender,please check to add MeshRender or delete MeshFilter."); - Debug.LogError(TmpSB.ToString()); + tmpStringBuilder.Length = 0; + tmpStringBuilder.Append(meshFilter.transform.name); + tmpStringBuilder.Append(" have meshFilter without any MeshRender,please check to add MeshRender or delete MeshFilter."); + Debug.LogError(tmpStringBuilder.ToString()); } }