Skip to content

Commit e668696

Browse files
committed
Use @handlebars/parser v2
We have to remove `--failAfterWarnings` from our Rollup integration-test, because Typescript, when targeting es5, will use global `this` for transpilation. Rollup warns about this, since it replaces `this` with `undefined`: ``` src/index.js → dist/bundle.js... (!) `this` has been rewritten to `undefined` https://rollupjs.org/guide/en/#error-this-is-undefined ../../../node_modules/@handlebars/parser/dist/esm/printer.js 1: var __spreadArrays = (this && this.__spreadArrays) || function () {} ``` See https://github.com/handlebars-lang/handlebars-parser/releases/tag/v2.0.0
1 parent 262b84b commit e668696

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"node": ">=12"
2121
},
2222
"dependencies": {
23-
"@handlebars/parser": "^1.1.0",
23+
"@handlebars/parser": "^2.1.0",
2424
"neo-async": "^2.6.2",
2525
"source-map": "^0.6.1",
2626
"yargs": "^16.2.0"

tests/integration/rollup-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"description": "Various tests with Handlebars and rollup",
44
"version": "1.0.0",
55
"scripts": {
6-
"build": "rollup --config rollup.config.js --failAfterWarnings"
6+
"build": "rollup --config rollup.config.js"
77
},
88
"private": true,
99
"devDependencies": {

0 commit comments

Comments
 (0)