added _parent and context to data returned by #with in helpers #1840#1952
Open
smmhatami wants to merge 1 commit intohandlebars-lang:masterfrom
Open
added _parent and context to data returned by #with in helpers #1840#1952smmhatami wants to merge 1 commit intohandlebars-lang:masterfrom
smmhatami wants to merge 1 commit intohandlebars-lang:masterfrom
Conversation
Signed-off-by: Seyed Mohammad Mahdi Hatami <hatamik7@gmail.com>
jaylinski
reviewed
Jun 23, 2023
Member
jaylinski
left a comment
There was a problem hiding this comment.
I think the right place for a test would be here:
handlebars.js/spec/builtins.js
Lines 136 to 184 in b4a54ad
Tests can be run via npm install and npm run test.
jaylinski
reviewed
Aug 25, 2023
Member
jaylinski
left a comment
There was a problem hiding this comment.
@smmhatami Can you add a test for this? (See comment above on where to add it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to solve Issue 1840. Resolves #1840. Added _parent and context to data returned by with in helpers just like each does to each iterated field.
I just couldn't find where and how should I add tests for this functionality, i would be glad if you help me with that.
thanks!