Skip to content

Conversation

jkiddo
Copy link
Contributor

@jkiddo jkiddo commented Mar 22, 2025

Added more tests NpmPackage parsing

@jkiddo
Copy link
Contributor Author

jkiddo commented Mar 22, 2025

Some harness around 3c7d13f

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.85%. Comparing base (e56ffed) to head (81465f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1938   +/-   ##
=========================================
  Coverage     12.85%   12.85%           
- Complexity    34479    34481    +2     
=========================================
  Files          2305     2305           
  Lines        698659   698659           
  Branches     205848   205848           
=========================================
+ Hits          89834    89843    +9     
+ Misses       576949   576939   -10     
- Partials      31876    31877    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grahamegrieve
Copy link
Collaborator

Note that cause of the failure - something in your packages. You can investigate as to whether the bi-di check is correct or not, or just withdraw the PR, since the actual problem is fixed now

@jkiddo
Copy link
Contributor Author

jkiddo commented Mar 29, 2025

bi-dir already ignores other package.tgz files - probably because its binary content:

IGNORE: i18n-coverage-table\.png$|dummy-package\.tgz$|dummy-package-no-index\.tgz$
- so that could be expanded to include those in the PR as well.

@grahamegrieve
Copy link
Collaborator

Well, do you want to make those changes then?

@dotasek
Copy link
Collaborator

dotasek commented May 26, 2025

bi-dir already ignores other package.tgz files - probably because its binary content:

IGNORE: i18n-coverage-table\.png$|dummy-package\.tgz$|dummy-package-no-index\.tgz$

  • so that could be expanded to include those in the PR as well.

Yes, that is the reason that those tgz files are excluded. @jkiddo, you can definitely add your tgz files to this list.

There are no .. or executables in any of these, btw, which we should be checking for when someone commits tgzs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants