-
Notifications
You must be signed in to change notification settings - Fork 184
Feat/slash in folder #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/slash in folder #1938
Conversation
Some harness around 3c7d13f |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1938 +/- ##
=========================================
Coverage 12.85% 12.85%
- Complexity 34479 34481 +2
=========================================
Files 2305 2305
Lines 698659 698659
Branches 205848 205848
=========================================
+ Hits 89834 89843 +9
+ Misses 576949 576939 -10
- Partials 31876 31877 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note that cause of the failure - something in your packages. You can investigate as to whether the bi-di check is correct or not, or just withdraw the PR, since the actual problem is fixed now |
bi-dir already ignores other package.tgz files - probably because its binary content:
|
Well, do you want to make those changes then? |
Yes, that is the reason that those tgz files are excluded. @jkiddo, you can definitely add your tgz files to this list. There are no |
Added more tests NpmPackage parsing