SQL on FHIR test runner and reporter #2185
Open
+13,624
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a test runner for SQL on FHIR functionality that executes the tests within the official SQL on FHIR v2 test suite.
It includes the following test classes in both the R4 and R5 modules:
I didn't make any attempt to de-duplicate code here, happy to look at that if you think it is desirable. I also just copied in the SQL on FHIR test cases. We could look at other approaches to this, such as Git submodules, but I didn't want to add this without any precedent within this repository.
The SQL on FHIR tests don't fail the build if they don't pass - they emit a JSON report into the target folder. It would be great if we could publish this to GitHub pages so that we can include it on the implementations page.
There are some failures, I anticipate that we can address these in follow-up PRs once the test reporting is in place.
Resolves FHIR/sql-on-fhir-v2#274
/cc @grahamegrieve