MINOR: cluster: check response code based on registration method

rmaticevic · mjuraga · commit f7eac0c8477d · 2021-07-20T13:53:41.000+02:00
diff --git a/configuration/cluster_sync.go b/configuration/cluster_sync.go
@@ -73,6 +73,11 @@ type ClusterSync struct {
 	ReloadAgent haproxy.IReloadAgent
 }
 
+var expectedResponseCodes = map[string]int{
+	"POST": 201,
+	"PUT":  200,
+}
+
 func (c *ClusterSync) Monitor(cfg *Configuration, cli *client_native.HAProxyClient) {
 	c.cfg = cfg
 	c.cli = cli
@@ -362,7 +367,7 @@ func (c *ClusterSync) issueJoinRequest(url, port, basePath string, registerPath
 	if err != nil {
 		return err
 	}
-	if resp.StatusCode != 201 {
+	if resp.StatusCode != expectedResponseCodes[registerMethod] {
 		return fmt.Errorf("status code not proper [%d] %s", resp.StatusCode, string(body))
 	}
 	var responseData Node

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,11 @@ type ClusterSync struct {`
`73`	`73`	`ReloadAgent haproxy.IReloadAgent`
`74`	`74`	`}`
`75`	`75`
	`76`	`+var expectedResponseCodes = map[string]int{`
	`77`	`+ "POST": 201,`
	`78`	`+ "PUT": 200,`
	`79`	`+}`
	`80`	`+`
`76`	`81`	`func (c ClusterSync) Monitor(cfg Configuration, cli *client_native.HAProxyClient) {`
`77`	`82`	`c.cfg = cfg`
`78`	`83`	`c.cli = cli`
`@@ -362,7 +367,7 @@ func (c *ClusterSync) issueJoinRequest(url, port, basePath string, registerPath`
`362`	`367`	`if err != nil {`
`363`	`368`	`return err`
`364`	`369`	`}`
`365`		`- if resp.StatusCode != 201 {`
	`370`	`+ if resp.StatusCode != expectedResponseCodes[registerMethod] {`
`366`	`371`	`return fmt.Errorf("status code not proper [%d] %s", resp.StatusCode, string(body))`
`367`	`372`	`}`
`368`	`373`	`var responseData Node`