BUG: use Run to restart a HAProxy process without zombie

ivanmatmati · oktalz · commit 3620b6e6dd5d · 2024-07-30T10:07:24.000+02:00
diff --git a/pkg/haproxy/process/direct-control.go b/pkg/haproxy/process/direct-control.go
@@ -73,7 +73,7 @@ func (d *directControl) Service(action string) (err error) {
 		}
 		cmd.Stdout = os.Stdout
 		cmd.Stderr = os.Stderr
-		return cmd.Start()
+		return cmd.Run()
 	default:
 		return fmt.Errorf("unknown command '%s'", action)
 	}

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ func (d *directControl) Service(action string) (err error) {`
`73`	`73`	`}`
`74`	`74`	`cmd.Stdout = os.Stdout`
`75`	`75`	`cmd.Stderr = os.Stderr`
`76`		`- return cmd.Start()`
	`76`	`+ return cmd.Run()`
`77`	`77`	`default:`
`78`	`78`	`return fmt.Errorf("unknown command '%s'", action)`
`79`	`79`	`}`