BUG/MINOR: fix panic in Global CR DeepCopy

hdurand0710 · oktalz · commit ac3fb32b4c03 · 2023-12-18T11:59:14.000Z
diff --git a/crs/api/core/v1alpha1/global.go b/crs/api/core/v1alpha1/global.go
@@ -47,6 +47,7 @@ func (in *GlobalSpec) DeepCopyInto(out *GlobalSpec) {
 		out.LogTargets = make([]*models.LogTarget, len(in.LogTargets))
 		for i, v := range in.LogTargets {
 			b, _ := v.MarshalBinary()
+			out.LogTargets[i] = &models.LogTarget{}
 			_ = out.LogTargets[i].UnmarshalBinary(b)
 		}
 	}
diff --git a/crs/api/core/v1alpha2/global.go b/crs/api/core/v1alpha2/global.go
@@ -47,6 +47,7 @@ func (in *GlobalSpec) DeepCopyInto(out *GlobalSpec) {
 		out.LogTargets = make([]*models.LogTarget, len(in.LogTargets))
 		for i, v := range in.LogTargets {
 			b, _ := v.MarshalBinary()
+			out.LogTargets[i] = &models.LogTarget{}
 			_ = out.LogTargets[i].UnmarshalBinary(b)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ func (in GlobalSpec) DeepCopyInto(out GlobalSpec) {`
`47`	`47`	`out.LogTargets = make([]*models.LogTarget, len(in.LogTargets))`
`48`	`48`	`for i, v := range in.LogTargets {`
`49`	`49`	`b, _ := v.MarshalBinary()`
	`50`	`+ out.LogTargets[i] = &models.LogTarget{}`
`50`	`51`	`_ = out.LogTargets[i].UnmarshalBinary(b)`
`51`	`52`	`}`
`52`	`53`	`}`