Skip to content

Commit d8738d0

Browse files
fabianonunesMo3m3n
authored andcommitted
BUG/MINOR: tcp service should respect --disable-ipv4/ipv6 flags
1 parent 0dab9d0 commit d8738d0

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

controller/handler.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ func (c *HAProxyController) initHandlers() {
4545
handler.TCPServices{
4646
SetDefaultService: c.setDefaultService,
4747
CertDir: c.Cfg.Env.FrontendCertDir,
48+
IPv4: !c.OSArgs.DisableIPV4,
4849
AddrIPv4: c.OSArgs.IPV4BindAddr,
50+
IPv6: !c.OSArgs.DisableIPV6,
4951
AddrIPv6: c.OSArgs.IPV6BindAddr,
5052
},
5153
handler.PatternFiles{},

controller/handler/tcp-services.go

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ import (
1414

1515
type TCPServices struct {
1616
SetDefaultService func(ingress *store.Ingress, frontends []string) (reload bool, err error)
17+
IPv4 bool
18+
IPv6 bool
1719
CertDir string
1820
AddrIPv4 string
1921
AddrIPv6 string
@@ -114,15 +116,19 @@ func (t TCPServices) createTCPFrontend(api api.HAProxyClient, frontendName, bind
114116
}
115117
var errors utils.Errors
116118
errors.Add(api.FrontendCreate(frontend))
117-
errors.Add(api.FrontendBindCreate(frontendName, models.Bind{
118-
Address: t.AddrIPv4 + ":" + bindPort,
119-
Name: "v4",
120-
}))
121-
errors.Add(api.FrontendBindCreate(frontendName, models.Bind{
122-
Address: t.AddrIPv6 + ":" + bindPort,
123-
Name: "v6",
124-
V4v6: true,
125-
}))
119+
if t.IPv4 {
120+
errors.Add(api.FrontendBindCreate(frontendName, models.Bind{
121+
Address: t.AddrIPv4 + ":" + bindPort,
122+
Name: "v4",
123+
}))
124+
}
125+
if t.IPv6 {
126+
errors.Add(api.FrontendBindCreate(frontendName, models.Bind{
127+
Address: t.AddrIPv6 + ":" + bindPort,
128+
Name: "v6",
129+
V4v6: true,
130+
}))
131+
}
126132
if sslOffload {
127133
errors.Add(api.FrontendEnableSSLOffload(frontend.Name, t.CertDir, false))
128134
}

0 commit comments

Comments
 (0)