Skip to content

Separate arcMap generation from writing to file #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Separate arcMap generation from writing to file #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8c3859
Separating arcMap generation and writing to disk
Nov 11, 2021
dde036d
Separation WIP
Nov 11, 2021
6f6ef91
Separation WIP
Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ContourTree/ContourTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ ContourTree::computeArcMap() {

return {arcNo, nodeids, nodefns, nodeTypes, arcs};
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added because of the additional loop? Based in this, the return statement is anyway inside the second loop. Was the first loop a copy paste error?

void ContourTree::output(std::string fileName) {
std::cout << "removing deg-2 nodes and computing segmentation" << std::endl;

Expand Down