refactor(keystore): Enable concurrent access for SafeSecretKey and SecureRandomKeyProvider #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables concurrent access to key material in both
SafeSecretKey
andSecureRandomKeyProvider
, aligning with the goals of #26. While both classes were technically thread-safe via synchronized blocks, they did not scale well in concurrent environments, blocking all threads during common operations likegetOrCreateKey()
orgetEncoded()
.Implementation Details
✅ SecureRandomKeyProvider
decryptedKey
with anAtomicReference<SecretKey>
.get()
check outside the synchronized block.✅ SafeSecretKey
lastCopy
is now anAtomicReference<ByteArray>
.lastCopy
(fix for Issue Enhance SafeSecretKey with XOR-based in-memory masking for stronger runtime security #23).getEncoded()
and reattempts the early return inside the lock.maskBuffer
with a simple heap-storedmask
, allowing safe concurrent reads without locking the buffer.Closes