refactor(crypto): Rename SafeBoxExecutor to CipherPoolExecutor #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renamed
SafeBoxExecutor
toCipherPoolExecutor
to better reflect its true responsibility and prevent confusion across SafeBox internals. This is in preparation for #42 (LRU trimming), whereCipherPoolExecutor
will also handle scheduled trimming tasks. The renaming clarifies that the executor is not meant for general SafeBox tasks.Implementation Details
SafeBoxExecutor
→CipherPoolExecutor
CipherPool.kt
to reflect ownershipCipherPoolExecutor
as a constructor argument toCipherPool
CipherPoolExecutor
interface withexecuteLoadTask(...)
andscheduleTrimmingTask(...)
DefaultCipherPoolExecutor
singleton as the default implementationCipherPool
internals to delegate refill tasks via theexecutor
Closes #49