Skip to content

Conversation

harrytmthy
Copy link
Owner

Summary

Renamed SafeBoxExecutor to CipherPoolExecutor to better reflect its true responsibility and prevent confusion across SafeBox internals. This is in preparation for #42 (LRU trimming), where CipherPoolExecutor will also handle scheduled trimming tasks. The renaming clarifies that the executor is not meant for general SafeBox tasks.

Implementation Details

  • Renamed SafeBoxExecutorCipherPoolExecutor
  • Moved it into the same file as CipherPool.kt to reflect ownership
  • Added CipherPoolExecutor as a constructor argument to CipherPool
  • Introduced CipherPoolExecutor interface with executeLoadTask(...) and scheduleTrimmingTask(...)
  • Provided DefaultCipherPoolExecutor singleton as the default implementation
  • Updated CipherPool internals to delegate refill tasks via the executor

Closes #49

@harrytmthy harrytmthy added this to the 1.2.0 milestone Jul 13, 2025
@harrytmthy harrytmthy self-assigned this Jul 13, 2025
@harrytmthy harrytmthy merged commit fd5f805 into main Jul 13, 2025
3 checks passed
@harrytmthy harrytmthy deleted the refactor/rename-safebox-executor branch July 13, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename SafeBoxExecutor to CipherPoolExecutor for clearer scope
1 participant