fix: Decouple encrypted entry map from blob store #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves Issue #54 by shifting the in-memory map of encrypted entries out of SafeBoxBlobStore and into SafeBox, ensuring immediate read/write access even before disk writes complete. This aligns with EncryptedSharedPreferences behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves Issue #54 by realigning
apply()behavior with EncryptedSharedPreferences (ESP), ensuringgetXxx()calls return the expected values immediately after.apply()is invoked, even before disk writes complete.This lays the foundation for performance enhancements to be explored in #55.
Implementation Details
Map<Bytes, ByteArray>) fromSafeBoxBlobStoretoSafeBox, allowing immediate in-memory updates without waiting for disk writes.getXxx(...),contains(...), andgetAll()now access a dedicated in-memoryentriesmap inSafeBox, mirroring ESP behavior.SafeBoxBlobStoreis now fully decoupled from in-memory access, triggered only duringcommit()orapply().SafeBoxBlobStore.loadPersistedEntries()to be called once during SafeBox's init to hydrate from disk.apply()no longer blocksgetXxx()correctness when using real dispatchers likeDispatchers.IO.getString_withRealIoDispatcher_shouldReturnCorrectValue()to verify async correctness under real-world scheduling conditions.Closes #54