feat: Enforce singleton instance per file #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrytmthy
force-pushed
the
feature/singleton-instance-per-file
branch
from
836d49e to
0fa89dd
Compare
- SafeBox.create(...) now returns the same instance for a given fileName - Deprecated close() and closeWhenIdle() with no-op bodies - Removed SafeBoxBlobFileRegistry as it's no longer needed
harrytmthy
force-pushed
the
feature/singleton-instance-per-file
branch
from
0fa89dd to
00f0db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enforces a singleton instance per fileName for SafeBox, simplifying lifecycle and state management. It prevents edge cases arising from concurrent instances referencing the same underlying blob store.
Implementation Details
SafeBox.create(...)now returns the same instance if one already exists for the given fileName.ConcurrentHashMap<String, SafeBox>to manage instance caching.stateListener, if provided on subsequent.create(...)calls, is forwarded to the existing instance viasetStateListener(...).close()andcloseWhenIdle()as SafeBox is now intended to be long-lived and reusable.SafeBoxBlobFileRegistryas manual registration is no longer necessary.Closes #58