Skip to content

fix: deleting all keys breaks Create and Share action#2241

Merged
svienot merged 2 commits into
mainfrom
key_setup_check
Feb 11, 2026
Merged

fix: deleting all keys breaks Create and Share action#2241
svienot merged 2 commits into
mainfrom
key_setup_check

Conversation

@ericleponner
Copy link
Copy Markdown
Contributor

@ericleponner ericleponner commented Feb 6, 2026

Description:
Changes below fix Sign and Execute and Create and Share behavior when no key is setup.
In this case, both actions display a modal dialog to give instructions to user and a button to navigate to Settings / Keys.

image

When needed, Sign and Execute and Create and Share action save transaction draft before navigating to Settings.

image

Related issue(s):

Fixes #2244

Notes for reviewers:

A   front-end/src/renderer/components/Transaction/TransactionProcessor/components/CheckKeySettingHandler.vue
M   front-end/src/renderer/components/Transaction/TransactionProcessor/TransactionProcessor.vue
    # CheckKeySettingHandler is a new handler executed first by TransactionProcessor.
    # When props.hasDataChanged, CheckKeySettingHandler saves transaction draft using props.saveDraft

M   front-end/src/renderer/components/Transaction/Create/BaseTransaction/BaseTransaction.vue
    # Now provides hasDataChanged and saveDraft props to TransactionProcessor so that
    # CheckKeySettingHandler can save draft when required

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (a349d15) to head (c4774ea).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   99.90%   99.89%   -0.01%     
==========================================
  Files         112      178      +66     
  Lines        3171     6828    +3657     
  Branches      511     1301     +790     
==========================================
+ Hits         3168     6821    +3653     
- Misses          3        7       +4     

see 66 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericleponner ericleponner changed the title Added CheckKeySettingHandler to TransactionProcessor. fix: deleting all keys breaks Create and Share action Feb 9, 2026
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner marked this pull request as ready for review February 10, 2026 15:16
@ericleponner ericleponner requested review from a team and yiliev0 as code owners February 10, 2026 15:16
Copy link
Copy Markdown
Contributor

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svienot svienot merged commit 5007ffa into main Feb 11, 2026
23 of 26 checks passed
@svienot svienot deleted the key_setup_check branch February 11, 2026 11:05
jbair06 pushed a commit that referenced this pull request Feb 12, 2026
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
(cherry picked from commit 5007ffa)
@steven-sheehy steven-sheehy added Bug A error that causes the feature to behave differently than what was expected based on design docs Frontend Frontend development work labels Feb 17, 2026
@steven-sheehy steven-sheehy added this to the v0.25.0 milestone Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug A error that causes the feature to behave differently than what was expected based on design docs Frontend Frontend development work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleting all keys breaks Create and Share action

3 participants