fix: deleting all keys breaks Create and Share action#2241
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 99.90% 99.89% -0.01%
==========================================
Files 112 178 +66
Lines 3171 6828 +3657
Branches 511 1301 +790
==========================================
+ Hits 3168 6821 +3653
- Misses 3 7 +4 🚀 New features to boost your workflow:
|
Create and Share action
5feebaf to
73adfea
Compare
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
73adfea to
265d9ba
Compare
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
jbair06
pushed a commit
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com> (cherry picked from commit 5007ffa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changes below fix
Sign and ExecuteandCreate and Sharebehavior when no key is setup.In this case, both actions display a modal dialog to give instructions to user and a button to navigate to
Settings/Keys.When needed,
Sign and ExecuteandCreate and Shareaction save transaction draft before navigating toSettings.Related issue(s):
Fixes #2244
Notes for reviewers:
Checklist