added dependencies for automation #6139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moduli
requested changes
Oct 10, 2025
moduli
reviewed
Oct 10, 2025
moduli
reviewed
Oct 13, 2025
| } | ||
|
|
||
| variable "github_token" { | ||
| description = "Github token" |
There was a problem hiding this comment.
Could we also add the updated description here?
moduli
reviewed
Oct 13, 2025
Comment on lines
+45
to
+47
| if (${github_token} -ne "") { | ||
| git config --global url."https://oauth2:${github_token}@github.com".insteadOf "https://github.com" | ||
| } |
There was a problem hiding this comment.
Not sure if this is being executed. I tried it on my machine and I don't see it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added dependencies for automation in the client setup script
Added an optional github token variable for running automation tests
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.