Add default exports to avoid build warnings

[alex-ju]

📌 Summary

Add export default to avoid build warnings and allow tidy imports.

🔗 External links

Jira ticket: HDS-4637 and HDS-3342

---

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist

• If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
• If applicable, I've worked with GRC to document the impact of any changes to security controls.
  Examples of changes to controls include access controls, encryption, logging, etc.
• If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
  Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
hds-showcase	✅ Ready (Inspect)	Visit Preview	Jun 12, 2025 4:16pm
hds-website	✅ Ready (Inspect)	Visit Preview	Jun 12, 2025 4:16pm

[aklkv]

is that really an issue? since we are ignoring this type of files, only warning we see in on the consumer side are:

[alex-ju]

is that really an issue? since we are ignoring this type of files, only warning we see in on the consumer side are:

not sure I follow @aklkv. could you please expand on your feedback here?

[RobbieTheWagner]

I'm curious what the underlying problem was here? To my knowledge, you are not required to have a default export in every file.

[alex-ju]

I'm curious what the underlying problem was here? To my knowledge, you are not required to have a default export in every file.

The build process is looking for default exports from several modules, and those modules were exporting named constants and functions instead. HCP raised a few times now that this adds unnecessary noise to their build logs so we're trying to act on feedback.

[aklkv]

@alex-ju totally correct, all ember specific folders like:

/components
/helpers
/services
/modifiers

only one real (meaning non type) default export, otherwise emberoider/webpack (this "issue" more like noise is only specific to webpack variant of embroider because how it build export map).

my feedback here we should fix it it's easy, otherwise I would prefere to direct our attention to single file components migration as it's much more important and becoming blocking addictianally it would not be even a problem with vit which is going to be predominant favour of build tooling for all projects that are going to migrate.

[aklkv]

I finally got time to look into this:

• there why to many default export if you look at my screenshots the only offending files are mostly modifiers to fix /types.ts files in modifiers folder modify this part in rollup.config.mjs by adding modifiers/**/!(*types).js', and maybe helpers as well for future.

  addon.appReexports([
    'components/**/!(*types).js',
    'helpers/**/*.js',
    'modifiers/**/*.js',
    'services/**/!(*types).js',
    'instance-initializers/**/*.js',
  ]),

• after above is fixed we would be left with following files that need default exports:

modifiers/hds-advanced-table-cell/dom-management
modifiers/hds-advanced-table-cell/keyboard-navigation
modifiers/hds-code-editor/languages/rego
modifiers/hds-code-editor/languages/sentinel
modifiers/hds-code-editor/palettes/hds-dark-palette

this would slim down your PR substantially, to see the result what we see when using hds in embroider context check our Run Tests for embroider-safe scenario, there would be one issues left which is fine

[alex-ju]

• there why to many default export if you look at my screenshots the only offending files are mostly modifiers to fix /types.ts files in modifiers folder modify this part in rollup.config.mjs by adding modifiers/**/!(*types).js', and maybe helpers as well for future.

  addon.appReexports([
    'components/**/!(*types).js',
    'helpers/**/*.js',
    'modifiers/**/*.js',
    'services/**/!(*types).js',
    'instance-initializers/**/*.js',
  ]),

I don't mind adding this exception, but there is only one types.js file in modifiers, so updating the rollup config has very minimal impact (one warning out of dozens)

• after above is fixed we would be left with following files that need default exports:

modifiers/hds-advanced-table-cell/dom-management modifiers/hds-advanced-table-cell/keyboard-navigation modifiers/hds-code-editor/languages/rego modifiers/hds-code-editor/languages/sentinel modifiers/hds-code-editor/palettes/hds-dark-palette

the above modifiers are already covered in this PR with default exports

this would slim down your PR substantially, to see the result what we see when using hds in embroider context check our Run Tests for embroider-safe scenario, there would be one issues left which is fine

I'm not sure I follow, what would slim down the PR substantially? as I mentioned above, the suggested change in rollup config only clears one warning. And yes, as mentioned in the tickets, I'm testing with pnpm ember try:one embroider-safe which seems to be similar to your process.

[alex-ju]

Closing this PR as we've been unable to align on a solution and it's been stalled in review for over a month. Since the changes were only intended to address non-functional build warnings, it's probably not worth pursuing further at this time.