Skip to content

Website Banner Audit: Accessibility Alert and Consideration #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 24, 2025

Conversation

andgen404
Copy link
Contributor

@andgen404 andgen404 commented Jul 15, 2025

📌 Summary

This PR includes updates to banners based on the banner audit work, specifically focusing on the banners in the Accessibility categories. The goal is to align banners in these categories to the latest writing guidelines, which defines two accessibility categories:

  • Title: Accessibility alert, Banner type: Warning
  • Title: Accessibility consideration, Banner type: Informational
  • Title: Accessibility tip, Banner type: Insight

To review, cross-reference with the categories from the audit in Figma and the new banner guidelines in Confluence.

🔗 External links

Jira ticket: HDS-5020

This PR contains banners that have been updated based off of the banner audit work. This group contains updated banners from the Accessibility section in Figma.
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 23, 2025 3:58pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 23, 2025 3:58pm

@hashibot-hds hashibot-hds added the docs-website Content updates to the documentation website label Jul 15, 2025
@andgen404 andgen404 changed the title Banner Audit: Accessibility Pitfalls and Tip Website Banner Audit: Accessibility Pitfalls and Tip Jul 15, 2025
@andgen404 andgen404 marked this pull request as ready for review July 16, 2025 21:47
@andgen404 andgen404 requested review from a team as code owners July 16, 2025 21:47
didoo
didoo previously approved these changes Jul 17, 2025
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the conflict in code that needs to be fixed, everything else seems OK to me.👌

Accessibility alert and consideration
@andgen404 andgen404 changed the title Website Banner Audit: Accessibility Pitfalls and Tip Website Banner Audit: Accessibility Alert and Consideration Jul 17, 2025
Copy link
Contributor

@LilithJames-HDS LilithJames-HDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some errors with the bold text, I noted where there were missing asterisks

Co-authored-by: Lilith James <lilith.james@hashicorp.com>
Co-authored-by: Lee White <lee.white@hashicorp.com>
zamoore
zamoore previously approved these changes Jul 22, 2025
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there may be a few banner type/title associations to adjust

Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
@andgen404 andgen404 requested a review from zamoore July 24, 2025 16:11
@andgen404 andgen404 merged commit c349b88 into main Jul 24, 2025
11 checks passed
@andgen404 andgen404 deleted the Banner-Audit-Accessibility branch July 24, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants