-
Notifications
You must be signed in to change notification settings - Fork 51
Website
Banner Audit: Accessibility Alert and Consideration
#3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR contains banners that have been updated based off of the banner audit work. This group contains updated banners from the Accessibility section in Figma.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Website
Banner Audit: Accessibility Pitfalls and Tip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the conflict in code that needs to be fixed, everything else seems OK to me.👌
Accessibility alert and consideration
Website
Banner Audit: Accessibility Pitfalls and TipWebsite
Banner Audit: Accessibility Alert and Consideration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some errors with the bold text, I noted where there were missing asterisks
website/docs/components/form/checkbox/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/form/file-input/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/form/file-input/partials/specifications/states.md
Outdated
Show resolved
Hide resolved
website/docs/components/form/masked-input/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lilith James <lilith.james@hashicorp.com>
website/docs/components/application-state/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/code-editor/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lee White <lee.white@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there may be a few banner type/title associations to adjust
website/docs/components/form/file-input/partials/specifications/states.md
Outdated
Show resolved
Hide resolved
website/docs/components/form/primitives/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/form/primitives/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Cristiano Rastelli <cristiano.rastelli@hashicorp.com>
📌 Summary
This PR includes updates to banners based on the banner audit work, specifically focusing on the banners in the Accessibility categories. The goal is to align banners in these categories to the latest writing guidelines, which defines two accessibility categories:
To review, cross-reference with the categories from the audit in Figma and the new banner guidelines in Confluence.
🔗 External links
Jira ticket: HDS-5020