Merge pull request #43184 from hashicorp/td-replace-PlanOnly-test-steps-2

Technical debt: Replace `PlanOnly` acceptance tests (services `g` - `w`)

Author: ewbankkit

.ci/semgrep/acctest/checks/planonly.yml

@@ -0,0 +1,15 @@
+rules:
+  - id: replace-planonly-checks
+    languages: [go]
+    message: Replace `PlanOnly` acceptance test steps with `plancheck`s
+    paths:
+      include:
+        - "internal/service/*/*_test.go"
+    patterns:
+      - pattern: |
+          {
+            ...,
+            PlanOnly: true,
+            ...
+          }
+    severity: ERROR

internal/generate/tagstests/resource_test.go.gtpl

@@ -492,8 +492,14 @@ func {{ template "testname" . }}_tags_null(t *testing.T) {
 					acctest.CtResourceTags: nil,
 					{{ template "AdditionalTfVars" . }}
 				},
-				PlanOnly:           true,
-				ExpectNonEmptyPlan: false,
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PreApply: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
+					},
+					PostApplyPostRefresh: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
+					},
+				},
 			},
 			{{- end }}
 		},
@@ -567,8 +573,14 @@ func {{ template "testname" . }}_tags_EmptyMap(t *testing.T) {
 					acctest.CtResourceTags: nil,
 					{{ template "AdditionalTfVars" . }}
 				},
-				PlanOnly:           true,
-				ExpectNonEmptyPlan: false,
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PreApply: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
+					},
+					PostApplyPostRefresh: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction(resourceName, plancheck.ResourceActionNoop),
+					},
+				},
 			},
 			{{- end }}
 		},

internal/sdkv2/schema.go

@@ -77,6 +77,9 @@ var IAMPolicyDocumentSchemaOptionalComputed = sync.OnceValue(jsonDocumentSchemaO
 // IAMPolicyDocumentSchemaRequired returns the standard schema for a required IAM policy JSON document.
 var IAMPolicyDocumentSchemaRequired = sync.OnceValue(jsonDocumentSchemaRequiredFunc(SuppressEquivalentIAMPolicyDocuments))
 
+// IAMPolicyDocumentSchemaRequiredForceNew returns the standard schema for a required, force-new IAM policy JSON document.
+var IAMPolicyDocumentSchemaRequiredForceNew = sync.OnceValue(jsonDocumentSchemaRequiredForceNewFunc(SuppressEquivalentIAMPolicyDocuments))
+
 // JSONDocumentSchemaOptionalForceNew returns the standard schema for an optional, force-new JSON document.
 var JSONDocumentSchemaOptionalForceNew = sync.OnceValue(jsonDocumentSchemaOptionalForceNewFunc(SuppressEquivalentJSONDocuments))
 
@@ -136,3 +139,17 @@ func jsonDocumentSchemaRequiredFunc(diffSuppressFunc schema.SchemaDiffSuppressFu
 		}
 	}
 }
+
+func jsonDocumentSchemaRequiredForceNewFunc(diffSuppressFunc schema.SchemaDiffSuppressFunc) func() *schema.Schema {
+	return func() *schema.Schema {
+		return &schema.Schema{
+			Type:                  schema.TypeString,
+			Required:              true,
+			ForceNew:              true,
+			ValidateFunc:          validation.StringIsJSON,
+			DiffSuppressFunc:      diffSuppressFunc,
+			DiffSuppressOnRefresh: true,
+			StateFunc:             NormalizeJsonStringSchemaStateFunc,
+		}
+	}
+}