Revert "add validation for iam policy document sid"

Author: DerekTBrown

.changelog/40562.txt

@@ -11,7 +11,6 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/YakDriver/regexache"
 	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -144,9 +143,8 @@ func dataSourcePolicyDocument() *schema.Resource {
 							"principals":        principalsSchema(),
 							names.AttrResources: setOfStringSchema(),
 							"sid": {
-								Type:         schema.TypeString,
-								Optional:     true,
-								ValidateFunc: validation.StringMatch(regexache.MustCompile(`^[a-zA-Z0-9]*$`), "must only include alphanumeric characters"),
+								Type:     schema.TypeString,
+								Optional: true,
 							},
 						},
 					},

internal/service/iam/policy_document_data_source.go

@@ -236,21 +236,6 @@ func TestAccIAMPolicyDocumentDataSource_overrideList(t *testing.T) {
 	})
 }
 
-func TestAccIAMPolicyDocumentDataSource_validateSid(t *testing.T) {
-	ctx := acctest.Context(t)
-	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:                 func() { acctest.PreCheck(ctx, t) },
-		ErrorCheck:               acctest.ErrorCheck(t, names.IAMServiceID),
-		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
-		Steps: []resource.TestStep{
-			{
-				Config:      testAccPolicyDocumentDataSourceConfig_invalidSid,
-				ExpectError: regexache.MustCompile(`must only include alphanumeric characters`),
-			},
-		},
-	})
-}
-
 func TestAccIAMPolicyDocumentDataSource_noStatementMerge(t *testing.T) {
 	ctx := acctest.Context(t)
 	resource.ParallelTest(t, resource.TestCase{
@@ -1037,18 +1022,6 @@ data "aws_iam_policy_document" "test_source_conflicting" {
 }
 `
 
-var testAccPolicyDocumentDataSourceConfig_invalidSid = `
-data "aws_iam_policy_document" "test" {
-  statement {
-    sid = "Invalid_SID"
-    actions = [
-      "s3:ListAllMyBuckets",
-      "s3:GetBucketLocation",
-    ]
-  }
-}
-`
-
 var testAccPolicyDocumentSourceConflictingExpectedJSON = `{
   "Version": "2012-10-17",
   "Statement": [