Merge pull request #10199 from terraform-providers/rfd-at002-eip

Import test refactor for EIP resources

Author: bflad

aws/provider_test.go

@@ -216,6 +216,16 @@ func testAccEC2ClassicPreCheck(t *testing.T) {
 	}
 }
 
+func testAccEC2VPCOnlyPreCheck(t *testing.T) {
+	client := testAccProvider.Meta().(*AWSClient)
+	platforms := client.supportedplatforms
+	region := client.region
+	if hasEc2Classic(platforms) {
+		t.Skipf("This test can only in regions without EC2 Classic, platforms available in %s: %q",
+			region, platforms)
+	}
+}
+
 func testAccHasServicePreCheck(service string, t *testing.T) {
 	if partition, ok := endpoints.PartitionForRegion(endpoints.DefaultPartitions(), testAccGetRegion()); ok {
 		if _, ok := partition.Services()[service]; !ok {

aws/resource_aws_eip_association_test.go

@@ -12,8 +12,9 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccAWSEIPAssociation_importInstance(t *testing.T) {
+func TestAccAWSEIPAssociation_instance(t *testing.T) {
 	resourceName := "aws_eip_association.test"
+	var a ec2.Address
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -22,6 +23,14 @@ func TestAccAWSEIPAssociation_importInstance(t *testing.T) {
 		Steps: []resource.TestStep{
 			{
 				Config: testAccAWSEIPAssociationConfig_instance,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckAWSEIPExists(
+						"aws_eip.test", &a),
+					testAccCheckAWSEIPAssociationExists(
+						resourceName, &a),
+					testAccCheckAWSEIPAssociationExists(
+						resourceName, &a),
+				),
 			},
 			{
 				ResourceName:      resourceName,
@@ -32,8 +41,9 @@ func TestAccAWSEIPAssociation_importInstance(t *testing.T) {
 	})
 }
 
-func TestAccAWSEIPAssociation_importNetworkInterface(t *testing.T) {
+func TestAccAWSEIPAssociation_networkInterface(t *testing.T) {
 	resourceName := "aws_eip_association.test"
+	var a ec2.Address
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -42,6 +52,12 @@ func TestAccAWSEIPAssociation_importNetworkInterface(t *testing.T) {
 		Steps: []resource.TestStep{
 			{
 				Config: testAccAWSEIPAssociationConfig_networkInterface,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckAWSEIPExists(
+						"aws_eip.test", &a),
+					testAccCheckAWSEIPAssociationExists(
+						resourceName, &a),
+				),
 			},
 			{
 				ResourceName:      resourceName,
@@ -54,35 +70,42 @@ func TestAccAWSEIPAssociation_importNetworkInterface(t *testing.T) {
 
 func TestAccAWSEIPAssociation_basic(t *testing.T) {
 	var a ec2.Address
+	resourceName := "aws_eip_association.by_allocation_id"
 
 	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:     func() { testAccPreCheck(t) },
+		PreCheck:     func() { testAccPreCheck(t); testAccEC2VPCOnlyPreCheck(t) },
 		Providers:    testAccProviders,
 		CheckDestroy: testAccCheckAWSEIPAssociationDestroy,
 		Steps: []resource.TestStep{
 			{
 				Config: testAccAWSEIPAssociationConfig,
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAWSEIPExists(
-						"aws_eip.bar.0", &a),
+						"aws_eip.test.0", &a),
 					testAccCheckAWSEIPAssociationExists(
 						"aws_eip_association.by_allocation_id", &a),
 					testAccCheckAWSEIPExists(
-						"aws_eip.bar.1", &a),
+						"aws_eip.test.1", &a),
 					testAccCheckAWSEIPAssociationExists(
 						"aws_eip_association.by_public_ip", &a),
 					testAccCheckAWSEIPExists(
-						"aws_eip.bar.2", &a),
+						"aws_eip.test.2", &a),
 					testAccCheckAWSEIPAssociationExists(
 						"aws_eip_association.to_eni", &a),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }
 
 func TestAccAWSEIPAssociation_ec2Classic(t *testing.T) {
 	var a ec2.Address
+	resourceName := "aws_eip_association.test"
 
 	oldvar := os.Getenv("AWS_DEFAULT_REGION")
 	os.Setenv("AWS_DEFAULT_REGION", "us-east-1")
@@ -97,19 +120,25 @@ func TestAccAWSEIPAssociation_ec2Classic(t *testing.T) {
 				Config: testAccAWSEIPAssociationConfig_ec2Classic,
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAWSEIPExists("aws_eip.test", &a),
-					testAccCheckAWSEIPAssociationExists("aws_eip_association.test", &a),
-					resource.TestCheckResourceAttrSet("aws_eip_association.test", "public_ip"),
-					resource.TestCheckResourceAttr("aws_eip_association.test", "allocation_id", ""),
-					testAccCheckAWSEIPAssociationHasIpBasedId("aws_eip_association.test", &a),
+					testAccCheckAWSEIPAssociationExists(resourceName, &a),
+					resource.TestCheckResourceAttrSet(resourceName, "public_ip"),
+					resource.TestCheckResourceAttr(resourceName, "allocation_id", ""),
+					testAccCheckAWSEIPAssociationHasIpBasedId(resourceName, &a),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }
 
 func TestAccAWSEIPAssociation_spotInstance(t *testing.T) {
 	var a ec2.Address
 	rInt := acctest.RandInt()
+	resourceName := "aws_eip_association.test"
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
@@ -120,11 +149,16 @@ func TestAccAWSEIPAssociation_spotInstance(t *testing.T) {
 				Config: testAccAWSEIPAssociationConfig_spotInstance(rInt),
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckAWSEIPExists("aws_eip.test", &a),
-					testAccCheckAWSEIPAssociationExists("aws_eip_association.test", &a),
-					resource.TestCheckResourceAttrSet("aws_eip_association.test", "allocation_id"),
-					resource.TestCheckResourceAttrSet("aws_eip_association.test", "instance_id"),
+					testAccCheckAWSEIPAssociationExists(resourceName, &a),
+					resource.TestCheckResourceAttrSet(resourceName, "allocation_id"),
+					resource.TestCheckResourceAttrSet(resourceName, "instance_id"),
 				),
 			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
 		},
 	})
 }
@@ -248,61 +282,90 @@ func testAccCheckAWSEIPAssociationDestroy(s *terraform.State) error {
 }
 
 const testAccAWSEIPAssociationConfig = `
-resource "aws_vpc" "main" {
+data "aws_availability_zones" "available" {
+	state = "available"
+}
+
+resource "aws_vpc" "test" {
 	cidr_block = "192.168.0.0/24"
 	tags = {
 		Name = "terraform-testacc-eip-association"
 	}
 }
-resource "aws_subnet" "sub" {
-	vpc_id = "${aws_vpc.main.id}"
+
+data "aws_ami" "amzn-ami-minimal-pv" {
+	most_recent = true
+	owners      = ["amazon"]
+
+	filter {
+	  name = "name"
+	  values = ["amzn-ami-minimal-pv-*"]
+	}
+}
+
+resource "aws_subnet" "test" {
+	vpc_id = "${aws_vpc.test.id}"
 	cidr_block = "192.168.0.0/25"
-	availability_zone = "us-west-2a"
+	availability_zone = "${data.aws_availability_zones.available.names[0]}"
 	tags = {
 		Name = "tf-acc-eip-association"
 	}
 }
-resource "aws_internet_gateway" "igw" {
-	vpc_id = "${aws_vpc.main.id}"
+resource "aws_internet_gateway" "test" {
+	vpc_id = "${aws_vpc.test.id}"
 }
-resource "aws_instance" "foo" {
+resource "aws_instance" "test" {
 	count = 2
-	ami = "ami-21f78e11"
-	availability_zone = "us-west-2a"
-	instance_type = "t1.micro"
-	subnet_id = "${aws_subnet.sub.id}"
+	ami = "${data.aws_ami.amzn-ami-minimal-pv.id}"
+	availability_zone = "${data.aws_availability_zones.available.names[0]}"
+	instance_type = "m1.small"
+	subnet_id = "${aws_subnet.test.id}"
 	private_ip = "192.168.0.${count.index+10}"
 }
-resource "aws_eip" "bar" {
+resource "aws_eip" "test" {
 	count = 3
 	vpc = true
 }
 resource "aws_eip_association" "by_allocation_id" {
-	allocation_id = "${aws_eip.bar.0.id}"
-	instance_id = "${aws_instance.foo.0.id}"
-	depends_on = ["aws_instance.foo"]
+	allocation_id = "${aws_eip.test.0.id}"
+	instance_id = "${aws_instance.test.0.id}"
+	depends_on = ["aws_instance.test"]
 }
 resource "aws_eip_association" "by_public_ip" {
-	public_ip = "${aws_eip.bar.1.public_ip}"
-	instance_id = "${aws_instance.foo.1.id}"
-	depends_on = ["aws_instance.foo"]
+	public_ip = "${aws_eip.test.1.public_ip}"
+	instance_id = "${aws_instance.test.1.id}"
+	depends_on = ["aws_instance.test"]
 }
 resource "aws_eip_association" "to_eni" {
-	allocation_id = "${aws_eip.bar.2.id}"
-	network_interface_id = "${aws_network_interface.baz.id}"
+	allocation_id = "${aws_eip.test.2.id}"
+	network_interface_id = "${aws_network_interface.test.id}"
 }
-resource "aws_network_interface" "baz" {
-	subnet_id = "${aws_subnet.sub.id}"
+resource "aws_network_interface" "test" {
+	subnet_id = "${aws_subnet.test.id}"
 	private_ips = ["192.168.0.50"]
-	depends_on = ["aws_instance.foo"]
+	depends_on = ["aws_instance.test"]
 	attachment {
-		instance = "${aws_instance.foo.0.id}"
+		instance = "${aws_instance.test.0.id}"
 		device_index = 1
 	}
 }
 `
 
 const testAccAWSEIPAssociationConfigDisappears = `
+data "aws_availability_zones" "available" {
+	state = "available"
+}
+
+data "aws_ami" "amzn-ami-minimal-pv" {
+	most_recent = true
+	owners      = ["amazon"]
+  
+	filter {
+	  name = "name"
+	  values = ["amzn-ami-minimal-pv-*"]
+	}
+}
+
 resource "aws_vpc" "main" {
 	cidr_block = "192.168.0.0/24"
 	tags = {
@@ -312,7 +375,7 @@ resource "aws_vpc" "main" {
 resource "aws_subnet" "sub" {
 	vpc_id = "${aws_vpc.main.id}"
 	cidr_block = "192.168.0.0/25"
-	availability_zone = "us-west-2a"
+	availability_zone = "${data.aws_availability_zones.available.names[0]}"
 	tags = {
 		Name = "tf-acc-eip-association-disappears"
 	}
@@ -321,9 +384,9 @@ resource "aws_internet_gateway" "igw" {
 	vpc_id = "${aws_vpc.main.id}"
 }
 resource "aws_instance" "foo" {
-	ami = "ami-21f78e11"
-	availability_zone = "us-west-2a"
-	instance_type = "t1.micro"
+	ami = "${data.aws_ami.amzn-ami-minimal-pv.id}"
+	availability_zone = "${data.aws_availability_zones.available.names[0]}"
+	instance_type = "m1.small"
 	subnet_id = "${aws_subnet.sub.id}"
 }
 resource "aws_eip" "bar" {
@@ -341,7 +404,9 @@ provider "aws" {
 
 resource "aws_eip" "test" {}
 
-data "aws_availability_zones" "available" {}
+data "aws_availability_zones" "available" {
+	state = "available"
+}
 
 data "aws_ami" "ubuntu" {
   most_recent = true