[Bug]: `aws_ecr_authorization_token` returns incorrect `proxy_endpoint` when `registry_id` is specified

[jscaltreto]

Terraform Core Version

1.8.1

AWS Provider Version

5.60.0

Affected Resource(s)

• aws_ecr_authorization_token data source

Expected Behavior

When specifying registry_id the proxy_endpoint returned should match the ECR registry endpoint of the specified account ID.

Actual Behavior

The proxy_endpoint returned is for the native account of the provider.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

data "aws_ecr_authorization_token" "ecr" {
  registry_id = "SOME ACCOUNT ID OTHER THAN THE ONE USED BY THE AWS PROVIDER"
}

Steps to Reproduce

• Use the aws_ecr_authorization_token data source
• Specify registry_id to any account other than the one the provider is authenticated with
• Observe the value of the proxy_endpoint attribute.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

It appears the code to handle the registry_id attribute was removed in the migration to AWS Go SDK v2. It seems registry_id is not relevant for issuing the authorization token as it will be valid for any registry the IAM principal has access to. However it remains relevant for the proxy_endpoint attribute.

This represents a breaking change in the provider since earlier versions would return the endpoint of the account specified by registry_id.

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.