[Enhancement]: Cross resource move support from aws_elasticsearch_domain to aws_opensearch_domain

[riconnon]

Description

AWS ElasticSearch service was renamed/rebranded to AWS OpenSearch service and domains in the former are automatically migrated to the latter.

The API for the ElasticSearch service remains in place for compatability and is still called by the aws_elasticsearch_domain and related resourced, but to use new features on domains the new API and resource type aws_opensearch_domain has to be used.

To best facilitate this the provider should support migrating resources from one to the other using a moved block.

Affected Resource(s) and/or Data Source(s)

• aws_elasticsearch_domain
• aws_opensearch_domain

Potential Terraform Configuration

resource "aws_opensearch_domain" "this" {
    domain_name = "example"
}

moved {
    from = aws_elasticsearch_domain.this
    to.  = aws_opensearch_domain.this
}

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[justinretzolk]

Linking to a relevant thread in the Terraform Core repo. Seems like this might be possible to implement as of very recently:

hashicorp/terraform#27310

[riconnon]

For anyone else happening upon this issue I've been able to workaround this using the following hack:

resource "aws_opensearch_domain" "this" {
    domain_name = local.name
    ...
}

// The following three blocks are a hack to workaround the AWS provider not supporting cross-type moves between
// Elasticsearch and OpenSearch. Instead we "forget" the resource using the lifecycle configuration in the removed block
// then do a data lookup for the name and import it under the new type.
removed {
  from = aws_elasticsearch_domain.this

  lifecycle {
    destroy = false
  }
}
data "aws_opensearch_domain" "this" {
  domain_name = local.name
}
import {
  id = data.aws_opensearch_domain.this.arn
  to = aws_opensearch_domain.this
}