development environment `make tools` step fails

[mbacchi]

Description

When following the development environment setup guide in a VScode devcontainer, one of the first steps make tools fails with the error:

vscode ➜ /workspaces/terraform-provider-aws-3 (main) $ make tools
make: Installing tools...
cd .ci/providerlint && go1.23.3 install .
...
cd .ci/tools && go1.23.3 install github.com/golangci/golangci-lint/cmd/golangci-lint
# github.com/golangci/golangci-lint/pkg/golinters/tagliatelle
/go/pkg/mod/github.com/golangci/golangci-lint@v1.62.2/pkg/golinters/tagliatelle/tagliatelle.go:13:3: unknown field Rules in struct literal of type "github.com/ldez/tagliatelle".Config
make: *** [GNUmakefile:677: tools] Error 1

It appears that golangci-lint v1.62.2 does not yet require tagliatelle v0.60 (though the next release will due to this unreleased change), which was an upgraded CI dependency 5 days ago in terraform-provider-aws/.ci/tools/go.mod. This causes an inconsinstency in the tagliatelle config file that isn't tolerated in the make tools process.

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[drewtul]

Looks like when that runs it installs from HEAD of main picking up their current go.mod, installing their latest release: github.com/golangci/golangci-lint/cmd/golangci-lint@v1.62.2 works fine.

[awgibbs]

I just ran into the same problem working off of main which I pulled fresh on Christmas Day. I ultimately got through it by adding the following to .ci/tools/go.mod...

replace github.com/ldez/tagliatelle => github.com/ldez/tagliatelle v0.5.0
replace github.com/nunnatsa/ginkgolinter => github.com/nunnatsa/ginkgolinter v0.18.3

... and then within .ci/tools doing "go mod tidy" and "go1.23.3 install" and then back at the root doing "make clean" and "make tools", which was an exercise in truing up the two library versions as seen in...

https://github.com/golangci/golangci-lint/blob/v1.62.2/go.mod

... on the thought that that would play better with the pinned 1.62.2 version of golangci-lint.

[jar-b]

Potentially resolved with the bump to 1.63.1 in #40742.

make tools completed without issue on my machine, but will wait for confirmation from those previously experiencing issues before closing this out.

[tomhunte]

I'm still seeing this when I do a clean git clone even after a complete re-installation of go on my computer.

Laptop: Apple MBP M3 - brew installed go version 1.23.4

[mbacchi]

Thanks @jar-b. This now appears to work using the original environment I had when I opened this issue. Namely running make tools after a clean git clone in a VSCode devcontainer.

[MarkDHarris]

I'm not finding a way around this. From a new git clone, when I use the .devcontainer I see this:

make tools
make: go1.23.9 not found
make: installing go1.23.9...
make: if you get an error, see https://go.dev/doc/manage-install to locally install various Go versions
go: downloading golang.org/dl v0.0.0-20250506174431-94083b956ef4
Downloaded   0.0% (   32768 / 70292777 bytes) ...
Downloaded   1.7% ( 1179648 / 70292777 bytes) ...
Downloaded  49.5% (34766016 / 70292777 bytes) ...
Downloaded  86.9% (61062704 / 70292777 bytes) ...
Downloaded 100.0% (70292777 / 70292777 bytes)
Unpacking /home/vscode/sdk/go1.23.9/go1.23.9.linux-arm64.tar.gz ...
Success. You may now run 'go1.23.9'
make: go1.23.9 ready
make: Installing tools...
cd .ci/providerlint && go1.23.9 install .
go: downloading github.com/bflad/tfproviderlint v0.31.0
go: downloading golang.org/x/tools v0.33.0
go: downloading github.com/bflad/gopaniccheck v0.1.0
go: downloading golang.org/x/sync v0.14.0
go: downloading golang.org/x/mod v0.24.0
cd .ci/tools && go1.23.9 install github.com/YakDriver/tfproviderdocs
go: go.mod requires go >= 1.24.3 (running go 1.23.9; GOTOOLCHAIN=local)
make: *** [GNUmakefile:710: tools] Error 1

And if I try to build on my local mac without the devcontainer but with using the asdf version manager and go 1.24.3 I see this:

make tools                  
make: Installing tools...
cd .ci/providerlint && go1.23.9 install .
go1.23.9: not downloaded. Run 'go1.23.9 download' to install to /Users/markharris/sdk/go1.23.9
make: *** [tools] Error 1

I checked the versions of tagliatelle and ginkgolinter as mentioned above by @awgibbs but the versions committed to the repo are already higher than the ones mentioned in the suggestion.

What do others do with their configuration to make git clone followed by make tools work successfully?