Skip to content

[Enhancement]: Deprecate uppercase versions of engine attribute in elasticache resource types #40813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gdavison opened this issue Jan 7, 2025 · 4 comments
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Jan 7, 2025

Description

A number of resource types in elasticache support both uppercase and lowercase versions of the engine attribute. Update them to standardize on the default lowercase. This will eventually allow removing diff suppression from the attribute.

Add deprecation warnings for uppercase values.

Affected Resource(s) and/or Data Source(s)

  • aws_elasticache_replication_group
  • aws_elasticache_serverless_cache
  • aws_elasticache_user
  • aws_elasticache_user_group

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

None

@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 7, 2025
@gdavison gdavison added this to the v6.0.0 milestone Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/elasticache Issues and PRs that pertain to the elasticache service. label Jan 7, 2025
@jar-b jar-b self-assigned this Apr 28, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 28, 2025
@jar-b
Copy link
Member

jar-b commented Apr 28, 2025

Breaking down the current state of case sensitivity and suppression functions in impacted resources. In order to be in-scope, the arguments validation must allow case insensitive values and include a diff suppression function.

Resource Case Insensitive Diff Suppression In-Scope
aws_elasticache_cluster 1 No No No
aws_elasticache_replication_group 2 Yes No No
aws_elasticache_serverless_cache 3 N/A (no validation at all) No No
aws_elasticache_user 4 Yes Yes Yes
aws_elasticache_user_group 5 Yes Yes Yes

@jar-b
Copy link
Member

jar-b commented Apr 30, 2025

Closed via #42419. These changes will be available in the v6.0.0 beta release later this month.

@jar-b jar-b closed this as completed Apr 30, 2025
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

No branches or pull requests

2 participants