Skip to content

fix(aws_dynamodb_table): Specify "name" for GlobalSecondaryIndex in flattenTableGlobalSecondaryIndex #41113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shion1305
Copy link

Description

Resolves #41110. When applying an aws_dynamodb_table with a Global Secondary Index (GSI) against the DynamoDB local emulator, Terraform consistently shows diffs for the GSI, even though no actual changes are made.

Investigation revealed that if ProvisionedThroughput is not configured, the name property for the GSI remains empty. This PR ensures that the name property is always set, preventing unnecessary diffs.

Relations

Closes #41110 (aws_dynamodb_table GSI shows unexpected diffs when using DynamoDB local emulator)

Output from Acceptance Testing

I was not able to setup environment for this test... 🙏

% make testacc TESTS=TestAccXXX PKG=ec2

...

…lSecondaryIndex

Resolves hashicorp#41110 (`aws_dynamodb_table` GSI shows unexpected diffs when using DynamoDB local emulator)
@Shion1305 Shion1305 requested a review from a team as a code owner January 28, 2025 00:02
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/dynamodb Issues and PRs that pertain to the dynamodb service. needs-triage Waiting for first response or review from a maintainer. labels Jan 28, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Shion1305 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 28, 2025
@Shion1305
Copy link
Author

Can this be included in the next release? I want to use the fixed version in my project asap 🙏🙏

@Shion1305
Copy link
Author

@justinretzolk Could you review this when you have a chance? 🙏 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/dynamodb Issues and PRs that pertain to the dynamodb service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] aws_dynamodb_table GSI shows unexpected diffs when using DynamoDB local emulator
2 participants