Skip to content

[Bug fix] run_configuration not part of update request resulting in default values #42387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neelrs
Copy link

@neelrs neelrs commented Apr 26, 2025

Description

AWS Managed Flink application allows mechanism to configure the runtime configuration that part of run_configuration attribute.
During the UpdateApplication workflow, if there is no change in the run_configuration the values are not passed with the Update request. This results in AWS setting them to default value.

Applications fail to start after updates when run_configuration.flink_run_configuration.allow_non_restored_state is defined as true. As this parameter isn't being properly preserved, the AWS default value is false, causing applications that require this setting to fail during update.

Output from Acceptance Testing

New acceptance test added TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRestorable for verifying the run_configuration across updates.

% make testacc TESTS=TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRestorable PKG=kinesisanalyticsv2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kinesisanalyticsv2/... -v -count 1 -parallel 20 -run='TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRestorable'  -timeout 360m -vet=off
2025/04/26 16:42:51 Initializing Terraform AWS Provider...
=== RUN   TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRestorable
=== PAUSE TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRestorable
=== CONT  TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRestorable
--- PASS: TestAccKinesisAnalyticsV2Application_FlinkApplication_updateRestorable (435.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2 440.385s


...

Copy link

github-actions bot commented Apr 26, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/XL Managed by automation to categorize the size of a PR. labels Apr 26, 2025
@neelrs neelrs marked this pull request as ready for review April 26, 2025 12:13
@neelrs neelrs requested a review from a team as a code owner April 26, 2025 12:13
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants